docs: 修正 CONTRIBUTING.md / ROADMAP.md 的 3 条死链 - #3571
Merged
Conversation
三条链接的目标在磁盘上都不存在,且这两个文件不在任何门禁的扫描面内 (check-doc-links 的 SCAN_ROOTS 是 content/docs + examples + 根 README; lychee 扫 content/docs、docs、README.md),所以一直静默失效。 - CONTRIBUTING.md:153 `./docs/spec/architecture.md`(`docs/spec/` 目录根本不存在) → `./content/docs/guide/architecture.md`。未按 issue 建议指向 `docs/ARCHITECTURE.md`: 该文件的 H1 是 "Console Streamlining - Architecture Guide",讲的是 app-shell/providers 那次重构的迁移路径,而链接所在的 "Architecture Overview" 一节讲的是 monorepo 包结构与 设计原则 —— `content/docs/guide/architecture.md`(标题即 "Architecture Overview", 含 Package Structure / Core Philosophy 两节)才是这句 "for details" 真正承诺的内容。 链接文字同时改成目标文档的真实标题,避免用旧标签包装另一个目标。 - CONTRIBUTING.md:469 `./docs/README.md` → 删除整句。仓库里没有、也从未有过 "Documentation Guide" 这份文档;它承诺的细节就在它所处的 Documentation 一节里 (Writing Documentation / Documentation Guidelines / Link Conventions / Validating Links), 前一句也已自成完整陈述。按 #3506/#3509 的先例,如实删除而不是改指别的文档。 - ROADMAP.md:1892 扩展名错 `.mdx` → `.md`。真实文件是 `content/docs/guide/plugin-development.md`;保持相对文件链接的写法,与同一列表里 `./CONTRIBUTING.md`、`./QUICK_REFERENCE.md` 一致。 本 PR 只做第 1 步。issue 的第 2 步(把这两个文件与 `docs/**` 纳入 SCAN_ROOTS) 刻意留下,不碰 scripts/check-doc-links.mjs。 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GTRjn8xBqp75dk7kFupVRt
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
yinlianghui
marked this pull request as ready for review
August 7, 2026 14:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3545
只做 issue 的第 1 步(3 条死链)。第 2 步(把这两个文件与
docs/**纳入SCAN_ROOTS)刻意留下,见文末。逐条处置
1.
CONTRIBUTING.md:153— 改指content/docs/guide/architecture.md(与 issue 的建议不同)docs/spec/目录根本不存在。issue 建议改指docs/ARCHITECTURE.md—— 该文件确实存在,但读过之后认为它不是这句话承诺的东西:docs/ARCHITECTURE.md的 H1 是# Console Streamlining - Architecture Guide,开篇即 "This document describes the refactored architecture that enables third-party systems to use ObjectUI components without inheriting the full console infrastructure";它的 "New Packages" 一节讲的是app-shell/providers,主体是 Before vs After、Migration Path —— 一份重构设计文档。## Architecture Overview一节,正文是packages/目录树(types、core、react、components、designer、plugin-*)加 5 条设计原则(Protocol Agnostic / Tailwind Native / Type Safety / Tree Shakable / Zero React in Core)。它要的 "details" 是包结构与设计原则的展开。content/docs/guide/architecture.md的 frontmatter title 就是Architecture Overview,含## Core Philosophy、## Architecture Layers、## Package Structure、## Type Safety—— 正是本节的展开版。链接文字同时从 "Architecture Documentation" 改成目标文档的真实标题 "Architecture Overview",避免 #3506 / #3509 反复强调的那个坑:用旧标签包装另一个目标。
2.
CONTRIBUTING.md:469— 整句删除docs/README.md不存在,且仓库里没有任何一份叫 "Documentation Guide" 的文档(docs/下只有ARCHITECTURE.md、CONSOLE-STREAMLINING-SUMMARY.md、adr/、audits/、screenshots/)。这句承诺的细节其实就在它自己所处的## Documentation一节里(Writing Documentation / Documentation Guidelines / Documentation Link Conventions / Validating Links 四个小节),前一句也已自成完整陈述。没有可诚实改指的目标 ⇒ 按 issue 给的第二种处置删句,而不是随手指一个别的文档。3.
ROADMAP.md:1892— 扩展名.mdx→.md真实文件是
.md。保持相对文件链接的写法(而不是 issue 提到的站内路由/docs/guide/plugin-development),与同一 Reference 列表里的./CONTRIBUTING.md、./QUICK_REFERENCE.md一致 —— 这三行是给 GitHub 上读 ROADMAP 的人看的,GitHub 供的是文件不是路由。验证
这两个文件在任何门禁的扫描面之外 —— 即便 PR #3542 落地之后也是:
SCAN_ROOTS现在是content/docs/examples/README.md,lychee 扫的是content/docs/**、docs/**、README.md。所以本 PR 没有"某个门禁由红转绿"的证据可给,磁盘存在性就是全部证据,如实说明:另外用脚本自己导出的
collectFiles/stripCode/diskPathExists(只读,未改脚本)按rule: 'disk'预跑了这三个候选面,改前 / 改后:现有门禁保持绿:
无 changeset:根仓贡献者文档,非发布产物。未触碰
content/docs/releases/。刻意未做:第 2 步(扫描面)
scripts/check-doc-links.mjs本 PR 一行未动。#3545 第 2 步(给SCAN_ROOTS加CONTRIBUTING.md/ROADMAP.md/docs三行)留在 #3545 里,给下一个座位。顺带把分诊评论里"
docs/**从没被量过"这个 caveat 量掉了(见上表):docs/**15 个文件、49 条链接、47 条会被disk规则判定、0 条死链。所以第 2 步的成本是"3 行配置 + 0 条清理",本 PR 落地后这三个面即刻就是绿的 —— 但这只是一次预跑,不构成实施。附带发现(未在本 PR 修)
#3570:同一节相邻散文的两处过期陈述 ——
CONTRIBUTING.md:467把 lychee 说成 PR 门禁(实为周扫 +workflow_dispatch,真正 gate PR 的是docs-links.yml),以及 "✅ Correct Link Patterns" 示例里 3 条路由(/docs/reference/api/core、/docs/reference/protocol/overview、/docs/architecture/component)用仓库自己的routeExists()判定为死。两者都不是死链,#3545 的修复不覆盖;且因为在代码围栏里被stripCode()抹掉,即便第 2 步落地也扫不到。Generated by Claude Code