docs(runner): 删掉 README 两处虚构能力面(createRunner/runner.config.js),修正 404 文档链接 (#3576) - #3602
Merged
Merged
Conversation
`createRunner()` / `runner.config.js` 全仓零代码引用,包也没有任何库入口 (main/module/exports/types 全无),按 #3533 的口径清除;`/docs/runner` 是死路由,改成实际存在的 `/docs/utilities/runner`。 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GTRjn8xBqp75dk7kFupVRt
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This was referenced Aug 7, 2026
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
Collaborator
Author
|
正文里两处"已另开 issue"的编号:
两条都未认领,留给 PM 分诊;本 PR 不碰。 Generated by Claude Code |
yinlianghui
marked this pull request as ready for review
August 7, 2026 15:44
This was referenced Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3576
按 #3533 的口径(文档不许描述实现里不存在的能力)清掉
packages/runner/README.md的两个虚构能力面,并修正一条 404 的文档链接。改动只落在这一个文件。三处处置与零命中证据
1. §Programmatic Usage(原 41-50 行)—— 整节删除,并把上方 §Installation 改写成 runner 的真实用法。
全仓仅此两行,且
packages/runner/package.json没有main/module/exports/types任何一个字段(files只有dist/README.md/CHANGELOG.md/LICENSE),所以import ... from '@object-ui/runner'无从解析 —— 这个包是index.html+src/main.tsx的 Vite 应用,不是库。选了 issue 给的第二个选项(改写为真实用法)而不是纯删,原因是纯删会留下一个孤儿:上方
## Installation教的pnpm add @object-ui/runner只在"可 import"的前提下才成立,而 issue 正文已把它点名为同一处虚构的连带面("因此也是误导:装了也没有可 import 的入口")。现在合并为一节## Running the Runner,与content/docs/utilities/runner.mdx的同名小节口径一致(clone →pnpm install→pnpm --filter @object-ui/runner dev),原来的pnpm dev/build/preview三条命令原样保留在下半段。删掉### Programmatic Usage后### As a Development Tool成了唯一的三级标题,一并拍平。2. §Configuration(原 98-112 行)——
runner.config.js删除,改写为真实的两个配置面。同样零代码引用(含未跟踪文件的全盘 grep 也只有这一行)。改写后指向实测存在的两处:
vite.config.ts(构建选项 + 让 runner 直接从 monorepo 源码启动的别名表;dev server 用 Vite 默认端口 5173,靠 Vite 自己的 flag 改)与?api=查询参数(指回本 README 已有的 §Metadata Loading 锚点,不重复叙述)。这与 #3594 刚落的 §Metadata Loading 那句"it reads no environment variables and no config file"互相印证;#3538 此前已清掉环境变量那一面,这是最后一处虚构配置面。3. §API Reference 的链接(原 167 行)——
/docs/runner→/docs/utilities/runner。路由核对(人工,理由见下):
content/docs/runner.*不存在;content/docs/utilities/runner.mdx存在,且content/docs/utilities/meta.json的pages里列了runner,content/docs/meta.json的pages里列了utilities。同一 README 底部## Links的 Documentation 一条本来就是这个 URL,package.json的homepage也是 —— 现在三处一致。顺带把标题
## API Reference改成## Documentation:这一节的正文本来就是"detailed documentation",而本 PR 刚刚确认这个包没有可引用的 API,留着 API Reference 是被删掉那套"库"叙事的最后残留。这是本 PR 唯一一处超出三条 issue 字面的改动,单独在此声明。改动后三条 grep 全部零命中:
全文一致性核对
今天有三个 PR 动过这个文件(#3581 / #3594,以及本 PR),所以通读了改后全文:开头第 3 行"standalone development server and runtime"、§Features 的"Built-in Vite development server"与新的 §Running the Runner 同调,全篇不再有"可 import 的库"这一叙事;新 §Configuration 与 §Metadata Loading 不冲突也不重复;
#metadata-loading锚点对应## Metadata Loading标题,有效。另确认没有任何文件链接到本 README 的旧锚点(git grep "runner/README\|#programmatic-usage\|#as-a-development-tool"只命中 CHANGELOG 里一句无关文字),所以拍平标题不会打断站内链接。通读时发现 §Development Workflow 第 1 步"Create a schema file (JSON or TypeScript)"与 §Metadata Loading 不符(两个 loader 都只认 JSON:
import.meta.glob('../app-data/**/*.json')与fetch(base + '/pages/x.json'))。不在本 issue 的三条范围内,未在本 PR 修改,已另开 issue 记录。验证
scripts/check-doc-links.mjs的SCAN_ROOTS只有content/docs/examples/ 根README.md,packages/**/README.md不在其中;而且即使在其中也没用 ——judgeHref()在check-doc-links.mjs:552对任何带 scheme 的 href 直接return null,唯一例外是SELF_REPO_BLOB_RE(本仓 github blob/tree URL),站内绝对地址https://www.objectui.org/docs/...从不做路由校验。所以docs:check-links那句绿是"没扫到",不是"扫过且通过"。这个盲区在别的包 README 上已经兑现成 9 处死链,已另开 issue。Changeset
无。 按 #3581 的先例(同样是
packages/runner/README.md+ docs 的纯文档 PR,无 changeset)。核对过没有门禁反对:CI 的changeset-check跑的是check-changeset-fixed.mjs(校验所有包在 fixed group 里,不要求每个 PR 带 changeset),changeset-guard跑的是check-changeset-no-major.mjs(只拦 major),两条本地都绿。README 确实进 npm tarball(files含README.md),但改的是纯错误叙述,没有版本语义。Generated by Claude Code