docs(scripts): 按真实机制改写两处 Lychee 门禁描述,并删掉 judgeHref 重复注释 (#3587) (#3648) - #3656
Merged
Conversation
两处注释称 lychee 是「weekly cron with continue-on-error」,结论「gates
nothing」对,机制反了:check-links.yml 里没有任何 continue-on-error,第 77 行
是 fail: true,`on:` 只有 workflow_dispatch + schedule('17 4 * * 0'),push 与
pull_request 被注释掉并附 ⛔ Do NOT enable(#3213 ruling B)。按错误理由行事的
人会去摘一行不存在的 continue-on-error,而真实风险相反 —— 取消注释
pull_request: 会让它立刻变成走网络的硬门禁。
改成同一文件 :194 起已有的正确表述(#3589 头注释措辞):schedule +
workflow_dispatch、无 PR 触发器,所以它谁也拦不住。
同时删掉 judgeHref() 里被逐字复制两遍的那 4 行注释(#3629 合并时的重复粘贴)。
纯注释改动,零行为变化;test 那处只改说明文字,断言未动。scripts/ 非发布包且
无用户可见变化,故无 changeset。
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GTRjn8xBqp75dk7kFupVRt
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This was referenced Aug 7, 2026
yinlianghui
marked this pull request as ready for review
August 7, 2026 17:42
yinlianghui
pushed a commit
that referenced
this pull request
Aug 7, 2026
The two sidebars' `sys-datasources` entry now names the canonical `…/metadata/datasource` route, so three comments claiming the setup left-nav points at the legacy alias became false as of the previous commit. Rewritten as positive statements of what is true now. Per #3656, none of them re-plants the alias URL in a denial sentence — a comment that says "no longer points at X" keeps a grep for X returning the very hit the rewrite was meant to clear. `console/AppContent.tsx` is a comment-only change: the two alias route declarations, and every other line of code, are untouched. Its #3610 history is preserved and extended rather than replaced — #3610 declined to re-point the navigation because a zero-app-only spelling would have given the alias a second canonical destination, and #3660 re-pointed it at the shared route, so that reasoning still holds. Fixes #3666 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GTRjn8xBqp75dk7kFupVRt
This was referenced Aug 7, 2026
This was referenced Aug 7, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3587
Fixes #3648
纯注释改动,零行为变化,两文件三处。
前提复核(先按内容锚定,再改)
正文引的行号确已大漂,但三处失真都还在
origin/main(93c2619,含 #3649):check-doc-links.mjs:157check-doc-links.test.ts:853check-doc-links.mjs:689-696git blame指向 0e4ea07(#3629).github/workflows/check-links.yml现状我重测过,不是照抄正文:fail: true;grep -rn 'continue-on-error' .github/在别的工作流(live-e2e / shadcn-check / performance-budget)有命中,check-links.yml 里一处都没有;on:只有workflow_dispatch与schedule: '17 4 * * 0';push:/pull_request:在 :44-47 被注释掉,上面就是⛔ Do NOT enable(pnpm docs:check-links在 main 上就退出 1,但没有任何工作流跑它(两个链接检查器都不拦 PR) #3213 ruling B)。所以「gates nothing」这个结论对,机制反了。
改动一:机制正确的表述(#3587)
scripts/check-doc-links.mjs(§2 自仓 blob/tree URL 那段):改前
改后
措辞对齐同一文件 :194 起已有的正确版本(#3589 写的头注释:"that workflow is
schedule+workflow_dispatchonly … so it blocks nobody")——同一文件里两种说法并存,本来就是下一个读者踩坑的地方。括号那句是 issue 的核心指控落地:按旧注释行事的人会去摘一行不存在的continue-on-error,而真实风险方向相反。scripts/__tests__/check-doc-links.test.ts:886,某断言上方的说明文字,只改文字,断言一行未动:改前
改后
改动二:删掉重复粘贴的 4 行(#3648)
judgeHref()里 "A URL on this site is an internal route wearing an origin…" 那 4 行出现两遍、一字不差,删掉后一份。先预测后验证
grep -rn 'continue-on-error' scripts/归零grep -rn 'weekly cron' scripts/归零node scripts/check-doc-links.mjs前后同输出Links are valid across 7 scan roots.exit 0check-links-workflow.test.ts共 89 passed / 2 files)pnpm type-check:scripts绿pnpm check:control-bytes绿OK (scanned 3661 tracked text file(s)),另加grep -naP自扫两文件干净一处没按预测走、如实记下:草稿里我曾在新注释中写 "carries no
continue-on-error" 来正面否认旧说法,那会让grep 'continue-on-error'停在 1 而不是 0。改用 "not a soft-failing job" 表达同一个意思,既保留了防误读的价值,又让 grep 真正归零。围栏
content/docs/guide/ci-cd-pipeline.md未动——它对该工作流的描述本身正确(issue 已确认)。.github/workflows/check-links.yml未动——本单只修注释,不改门禁行为。scripts/不是发布包,且改动纯注释、零用户可见变化。scripts/新增 en-drift 门禁文件)实测零相交。pnpm exec prettier --check对这两文件报 warn,但改前的 origin/main 版本同样报(默认配置下 389 / 1646 行差异),仓内既无 prettier 配置也无任何工作流跑 prettier——非本 PR 引入,不处理。🤖 Generated with Claude Code
https://claude.ai/code/session_01GTRjn8xBqp75dk7kFupVRt
Generated by Claude Code