fix(components,plugin-detail): 动作 disabled 的「已声明」判定剩余五处改读 hasDeclaredVisibilityGate (#3849)

.changeset/action-member-declared-disabled-gate-3849.md

@@ -0,0 +1,50 @@
+---
+"@object-ui/components": patch
+"@object-ui/plugin-detail": patch
+---
+
+`disabled: ''` no longer greys out the remaining five action surfaces (objectui#3849)
+
+objectui#3842 / PR #3851 fixed the "is a `disabled` gate DECLARED?" test on
+`action:button` and app-shell's `DeclaredActionsBar`. Five same-shaped sites were
+outside that PR's scope and stayed on `!= null`, so within one component the
+`visible` gate asked `hasDeclaredVisibilityGate` while the `disabled` gate on the
+next line asked `!= null` — two spellings of one question:
+
+- `@object-ui/components` — `action:icon`, `action:group`'s inline button
+  (`InlineActionButton`) and dropdown item (`DropdownActionItem`), and
+  `action:menu`'s item (`ActionMenuItem`).
+- `@object-ui/plugin-detail` — `record:quick_actions`' `QuickActionButton`.
+
+Why the missing `!== ''` half is a defect on this key and not on `visible`:
+`toPredicateInput('')` is `undefined` and `evaluateCondition(undefined)` is
+`true`. On `visible` that `true` means SHOW, so an over-broad "declared" test and
+a permissive empty predicate cancel out. On `disabled` it means DISABLE, so they
+compound — `disabled: ''` (an empty predicate: nothing declared) rendered a
+permanently greyed-out control, with nothing the author could write to un-grey
+it. Unlike #3842's approvals inbox, these five are the general action face
+(toolbars, dropdowns, record quick actions), so the reach is wider even though no
+single high-value host owns them.
+
+**Behaviour change surface, deliberately narrow.** Only `disabled: ''` changes —
+from disabled to clickable, which is what "no predicate" asked for. `disabled:
+true` still disables, `disabled: false` and an absent `disabled` still do not, and
+no expression-valued `disabled` changes verdict. On the four sites that also carry
+the legacy non-spec `enabled` fallback, one consequence follows: an empty
+`disabled` now falls THROUGH to that leg instead of short-circuiting on the empty
+predicate, so an action spelling both (`disabled: ''` + `enabled: true`) becomes
+clickable. `record:quick_actions` has no `enabled` leg, so its chain is the single
+gate.
+
+Routing those legacy `enabled` legs through the same definition is
+behaviour-preserving by derivation rather than a fix: the leg is negated
+(`disabled = !isEnabled`), so an empty predicate's `true` already arrived as "not
+disabled" — the verdict "no gate declared" produces. #3842's four-shape derivation
+table is reproduced next to the new pins, together with the statement that no
+`enabled` case can go red by reverting that leg.
+
+`hasDeclaredVisibilityGate` keeps its historic name (the objectui#3842 ruling): the
+predicate is key-neutral, and one implementation behind two names is how a repo
+grows dialects. The three `@object-ui/components` sites import it relatively;
+`record:quick_actions` takes it from the package barrel, the cross-package route
+objectui#3835 opened. Every call site says so in a comment.

packages/components/src/renderers/action/__tests__/action-member-disabled-declared-gate.test.tsx

@@ -0,0 +1,236 @@
+/**
+ * ObjectUI
+ * Copyright (c) 2024-present ObjectStack Inc.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+/**
+ * objectui#3849 — the declared-`disabled` gate on the four remaining action-face
+ * sites. objectui#3842 / PR #3851 fixed `action:button` (and app-shell's
+ * `DeclaredActionsBar`); these four stayed on `!= null`, so the same component
+ * asked "is a gate DECLARED?" one way for `visible` and another for `disabled`.
+ *
+ * The mechanism is #3842's, verbatim: `toPredicateInput('')` is `undefined` and
+ * `evaluateCondition(undefined)` is `true`. On `visible` that `true` means SHOW,
+ * so an over-broad "declared" test and a permissive empty predicate cancel out.
+ * On `disabled` the same `true` means DISABLE, so they compound — `disabled: ''`
+ * (an empty predicate, i.e. nothing declared) became "greyed out forever", with
+ * nothing the author could write to un-grey it. All four now read
+ * `hasDeclaredVisibilityGate` (`!= null && !== ''`), imported rather than
+ * re-spelled; historic name kept per the #3842 ruling.
+ *
+ * ## What each case detects
+ *
+ *   • `disabled: ''` → NOT disabled. THE defect, and a genuine mutation
+ *     detector on this key: restore `!= null` at one site and that site's `''`
+ *     case alone goes red (the reverse-verification this PR ran).
+ *   • `disabled: true` → disabled; `disabled: false` / undeclared → not
+ *     disabled. Anti-mutation guards: "never disable anything" satisfies three
+ *     of the four shapes on its own, and `true` is what refuses it.
+ *   • expression-valued `disabled` → the verdict still decides, both ways. The
+ *     gate narrowed; evaluation did not change.
+ *
+ * ## The legacy `enabled` leg — four cases that are documentation, one that moves
+ *
+ * The leg is NEGATED (`disabled = !isEnabled`), so an empty predicate's `true`
+ * arrives as `!true` = "not disabled", which is exactly what "no gate declared"
+ * produces. Every shape reaches the same verdict under either test, so the
+ * tightening is behaviour-preserving by derivation (#3842's table):
+ *
+ *   | `enabled`   | `!= null` (old)           | `hasDeclaredVisibilityGate` (new) |
+ *   |-------------|---------------------------|-----------------------------------|
+ *   | `''`        | gate → `!true`  = enabled | no gate → `false` = enabled       |
+ *   | `true`      | gate → `!true`  = enabled | gate → `!true`  = enabled         |
+ *   | `false`     | gate → `!false` = DISABLED| gate → `!false` = DISABLED        |
+ *   | undeclared  | no gate → `false`         | no gate → `false`                 |
+ *
+ * Stated plainly rather than dressed up as coverage: no `enabled` case here can
+ * go red by reverting the `enabled` leg. They are kept because they pin the
+ * semantics the derivation asserts (`enabled: false` must still disable), which
+ * a future rewrite of this chain would otherwise break silently. The case that
+ * DOES move is precedence: with `disabled: ''` no longer a gate, the chain falls
+ * through to the legacy leg instead of short-circuiting on an empty predicate.
+ */
+
+import { describe, it, expect } from 'vitest';
+import { render, screen } from '@testing-library/react';
+import '@testing-library/jest-dom';
+import React from 'react';
+import { ComponentRegistry } from '@object-ui/core';
+import { PredicateScopeProvider } from '@object-ui/react';
+// Module-scope side-effect imports so the two hosts are in the registry when
+// `ComponentRegistry.get` runs — the light `dom` project deliberately does not
+// load the `@object-ui/components` graph. Module scope, not a `beforeAll`, per
+// AGENTS.md §测试纪律: the cost lands in the import phase, unbounded by any
+// hook timeout.
+import '../action-icon';
+import { DropdownActionItem } from '../action-group';
+import { ActionMenuItem } from '../action-menu';
+import { DropdownMenu, DropdownMenuContent, DropdownMenuTrigger } from '../../../ui';
+
+const LABEL = 'Act';
+const ACT = { name: 'act', label: LABEL, type: 'script' };
+
+/** An ungated companion — a passing assertion must not mean "the host vanished". */
+const COMPANION = { name: 'view', label: 'View', type: 'script' };
+
+function getRenderer(type: string) {
+  const R = ComponentRegistry.get(type);
+  if (!R) throw new Error(`${type} is not registered`);
+  return R;
+}
+
+/**
+ * Site 1 — `action:icon`, mounted the way `action:bar` mounts a member: the
+ * whole action spread onto the leaf's own `schema` (`action-bar.tsx` resolves
+ * the renderer from the registry itself, so this gate is the only one on that
+ * path — the reachability #3823 established for the `visible` half of the same
+ * two lines).
+ */
+function mountIcon(action: any, scope: Record<string, any> = {}) {
+  const Renderer = getRenderer('action:icon');
+  return render(
+    <PredicateScopeProvider scope={scope}>
+      <Renderer schema={{ ...action, type: 'action:icon', actionType: action.type }} />
+    </PredicateScopeProvider>,
+  );
+}
+
+/**
+ * Site 2 — `InlineActionButton`, through the real `action:group` host so the
+ * member gate is observed where it runs (the group `.map()`s its own `actions`;
+ * neither `SchemaRenderer` nor `ActionEngine` is in this path).
+ */
+function mountInlineGroup(action: any, scope: Record<string, any> = {}) {
+  const Group = getRenderer('action:group');
+  return render(
+    <PredicateScopeProvider scope={scope}>
+      <Group schema={{ type: 'action:group', display: 'inline', actions: [action, COMPANION] }} />
+    </PredicateScopeProvider>,
+  );
+}
+
+/**
+ * Sites 3 and 4 — the two dropdown leaves, each inside a controlled-open menu so
+ * the portal content mounts deterministically (Radix opens on pointerdown, flaky
+ * to synthesize in happy-dom). Same harness as
+ * `action-group-dropdown-visible.test.tsx` and `action-member-visible-gate.test.tsx`.
+ */
+function mountInMenu(node: React.ReactNode, scope: Record<string, any> = {}) {
+  return render(
+    <PredicateScopeProvider scope={scope}>
+      <DropdownMenu open modal={false}>
+        <DropdownMenuTrigger>menu</DropdownMenuTrigger>
+        <DropdownMenuContent>{node}</DropdownMenuContent>
+      </DropdownMenu>
+    </PredicateScopeProvider>,
+  );
+}
+
+/** A `<button disabled>` leaf: the DOM property is the verdict. */
+const buttonIsDisabled = (label: string) =>
+  (screen.getByRole('button', { name: label }) as HTMLButtonElement).disabled;
+
+/**
+ * A Radix `DropdownMenuItem` leaf: it is a `role="menuitem"` div, so a disabled
+ * item carries `data-disabled` rather than the `disabled` attribute (the probe
+ * `action-group-dropdown-visible.test.tsx` established for #1885).
+ */
+const menuItemIsDisabled = (label: string) => {
+  const item = screen.getByText(label).closest('[role="menuitem"]');
+  if (!item) throw new Error(`no menuitem found for "${label}"`);
+  return item.hasAttribute('data-disabled');
+};
+
+interface Site {
+  /** Site name, as it reads in the test output. */
+  id: string;
+  mount: (action: any, scope?: Record<string, any>) => { unmount: () => void };
+  isDisabled: (label: string) => boolean;
+}
+
+const SITES: Site[] = [
+  { id: 'action:icon', mount: mountIcon, isDisabled: buttonIsDisabled },
+  { id: 'action:group inline member', mount: mountInlineGroup, isDisabled: buttonIsDisabled },
+  {
+    id: 'action:group dropdown member',
+    mount: (action, scope) =>
+      mountInMenu(<DropdownActionItem action={action} index={0} onSelect={() => {}} />, scope),
+    isDisabled: menuItemIsDisabled,
+  },
+  {
+    id: 'action:menu member',
+    mount: (action, scope) =>
+      mountInMenu(<ActionMenuItem action={action} onExecute={async () => {}} />, scope),
+    isDisabled: menuItemIsDisabled,
+  },
+];
+
+describe.each(SITES)('$id — declared `disabled` gate (objectui#3849)', ({ mount, isDisabled }) => {
+  it("an empty-string `disabled` is not a declared gate — the action stays clickable", () => {
+    mount({ ...ACT, disabled: '' });
+    expect(isDisabled(LABEL)).toBe(false);
+  });
+
+  it('disabled:true → the action is disabled', () => {
+    mount({ ...ACT, disabled: true });
+    expect(isDisabled(LABEL)).toBe(true);
+  });
+
+  it('disabled:false → the action is not disabled', () => {
+    mount({ ...ACT, disabled: false });
+    expect(isDisabled(LABEL)).toBe(false);
+  });
+
+  it('no `disabled` at all → the action is not disabled (ungated stays ungated)', () => {
+    mount({ ...ACT });
+    expect(isDisabled(LABEL)).toBe(false);
+  });
+
+  it('an expression-valued `disabled` keeps its verdict — true disables, false does not', () => {
+    const gated = { ...ACT, disabled: 'features.locked == true' };
+    const { unmount } = mount(gated, { features: { locked: true } });
+    expect(isDisabled(LABEL)).toBe(true);
+    unmount();
+    mount(gated, { features: { locked: false } });
+    expect(isDisabled(LABEL)).toBe(false);
+  });
+});
+
+describe.each(SITES)('$id — legacy `enabled` leg (objectui#3849)', ({ mount, isDisabled }) => {
+  it("an empty-string `enabled` is not a declared gate — the action stays clickable", () => {
+    mount({ ...ACT, enabled: '' });
+    expect(isDisabled(LABEL)).toBe(false);
+  });
+
+  it('enabled:false → the action is disabled (the legacy leg still decides)', () => {
+    mount({ ...ACT, enabled: false });
+    expect(isDisabled(LABEL)).toBe(true);
+  });
+
+  it('enabled:true → the action is not disabled', () => {
+    mount({ ...ACT, enabled: true });
+    expect(isDisabled(LABEL)).toBe(false);
+  });
+
+  it('an empty `disabled` falls THROUGH to the legacy `enabled` leg', () => {
+    // The precedence case, and the second one the narrowing moves: `disabled:
+    // ''` used to short-circuit the chain on an empty predicate (→ disabled), so
+    // the author's `enabled: true` was never consulted. With `''` no longer a
+    // gate, the legacy leg decides — "no `disabled` declared" means exactly
+    // that, whatever else the action declares.
+    mount({ ...ACT, disabled: '', enabled: true });
+    expect(isDisabled(LABEL)).toBe(false);
+  });
+
+  it('an empty `disabled` does not mask a legacy `enabled: false`', () => {
+    // Same fall-through, opposite verdict: the legacy leg is reached and says
+    // disabled. Green before and after (the old chain also disabled, for the
+    // wrong reason) — it is here so the fall-through cannot degrade into "read
+    // the `enabled` leg only when it agrees with not-disabled".
+    mount({ ...ACT, disabled: '', enabled: false });
+    expect(isDisabled(LABEL)).toBe(true);
+  });
+});

packages/components/src/renderers/action/action-group.tsx

@@ -102,10 +102,19 @@ const InlineActionButton: React.FC<{
       variant={btnVariant as any}
       size={btnSize as any}
       className={action.className}
+      // Is a `disabled` / `enabled` gate DECLARED? Same question as the
+      // `visible` gate above, so it reads the same definition (historic name
+      // kept, not aliased — objectui#3842 ruling, applied here by #3849). On
+      // this key `!= null` alone was a live defect: an empty predicate reaches
+      // the evaluation entry as "no condition → true", which means DISABLE
+      // here, so `disabled: ''` greyed the button out forever. The legacy
+      // `enabled` leg is negated and therefore behaviour-preserving under the
+      // same definition — derivation in
+      // `__tests__/action-disabled-declared-gate.test.tsx`.
       disabled={(
-        (action as any).disabled != null
+        hasDeclaredVisibilityGate((action as any).disabled)
           ? isDisabledPred
-          : action.enabled != null
+          : hasDeclaredVisibilityGate(action.enabled)
             ? !isEnabled
             : false
       ) || loading}
@@ -145,9 +154,14 @@ export const DropdownActionItem: React.FC<{
   // hidden in one display mode and shown in the other (objectui#3812).
   if (hasDeclaredVisibilityGate(action.visible) && !isVisible) return null;
   const Icon = resolveIcon(action.icon);
-  const isDisabled = (action as any).disabled != null
+  // Declared-gate test, same definition as `InlineActionButton` above: one
+  // action cannot be greyed out in one display mode and clickable in the other
+  // (objectui#3842 / #3849). `disabled: ''` is not a declared gate — an empty
+  // predicate is nothing to evaluate, and on this key the evaluation entry's
+  // "no condition → true" means DISABLE.
+  const isDisabled = hasDeclaredVisibilityGate((action as any).disabled)
     ? isDisabledPred
-    : action.enabled != null
+    : hasDeclaredVisibilityGate(action.enabled)
       ? !isEnabled
       : false;
   const showSeparator = action.tags?.includes('separator-before') && index > 0;

packages/components/src/renderers/action/action-icon.tsx

@@ -93,10 +93,25 @@ const ActionIconRenderer = forwardRef<HTMLButtonElement, ActionIconProps>(
         variant={variant as any}
         size={size}
         className={cn('h-8 w-8', schema.className, className)}
+        // Is a `disabled` / `enabled` gate DECLARED? The same question the
+        // `visible` gate above asks, so it reads the same definition — the name
+        // is historic (objectui#3492 arrived through `visible`), the predicate
+        // is key-neutral: "declared" is `!= null && !== ''`. Deliberately NOT
+        // renamed or aliased (objectui#3842 ruling, applied here by #3849).
+        //
+        // `!= null` alone was a live defect on `disabled` in a way it is not on
+        // `visible`: the evaluation entry reads an empty predicate as "no
+        // condition → true", which means SHOW on `visible` (harmless) but
+        // DISABLE here — `disabled: ''` was a permanently greyed-out button.
+        // The legacy `enabled` leg is negated, so its `''` case already landed
+        // on "not disabled"; routing it through the same definition is
+        // behaviour-preserving (derivation table in
+        // `__tests__/action-disabled-declared-gate.test.tsx`) and leaves one
+        // spelling of "declared" on both legs.
         disabled={(
-          (schema as any).disabled != null
+          hasDeclaredVisibilityGate((schema as any).disabled)
             ? isDisabledPred
-            : schema.enabled != null
+            : hasDeclaredVisibilityGate(schema.enabled)
               ? !isEnabled
               : false
         ) || loading}

packages/components/src/renderers/action/action-menu.tsx

@@ -95,9 +95,16 @@ export const ActionMenuItem: React.FC<{
 
   return (
     <DropdownMenuItem
-      disabled={(action as any).disabled != null
+      // Declared-gate test, the same definition the `visible` gate above reads
+      // and the same one `action:group`'s two leaves read (objectui#3842 ruling
+      // applied here by #3849 — historic name kept, no alias). `disabled: ''`
+      // is not a gate: the evaluation entry reads an empty predicate as "no
+      // condition → true", which on this key means DISABLE, so `!= null` alone
+      // greyed the item out forever. The negated legacy `enabled` leg is
+      // behaviour-preserving under the same definition.
+      disabled={hasDeclaredVisibilityGate((action as any).disabled)
         ? isDisabledPred
-        : action.enabled != null
+        : hasDeclaredVisibilityGate(action.enabled)
           ? !isEnabled
           : false}
       onSelect={(e) => {