[WIP] Update CI workflow for better efficiency#387
[WIP] Update CI workflow for better efficiency#387hotlong merged 2 commits intodependabot/npm_and_yarn/vitest-4.0.18from
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
hotlong
merged commit d21e232
into
dependabot/npm_and_yarn/vitest-4.0.18
There was a problem hiding this comment.
Pull request overview
This PR addresses a test failure in SpecCompliance.test.tsx by changing the import source from objectstack.shared.ts to objectstack.config.ts. The description indicates this was necessary to fix test failures and all 794 tests are now passing.
Changes:
- Updated import in SpecCompliance.test.tsx from
../../objectstack.sharedto../../objectstack.config
|
|
||
| import { describe, it, expect } from 'vitest'; | ||
| import appConfig from '../../objectstack.shared'; | ||
| import appConfig from '../../objectstack.config'; |
There was a problem hiding this comment.
The PR title mentions "Update CI workflow for better efficiency" but the actual changes only modify an import statement in a test file. There are no changes to any CI workflow files in .github/workflows/. Either the PR title should be updated to reflect the actual changes (e.g., "Fix SpecCompliance test import") or the intended CI workflow changes are missing from this PR.
|
|
||
| import { describe, it, expect } from 'vitest'; | ||
| import appConfig from '../../objectstack.shared'; | ||
| import appConfig from '../../objectstack.config'; |
There was a problem hiding this comment.
This import change creates an inconsistency in the codebase. While this test now imports from 'objectstack.config', there are at least 7 other files in the same app that still import from 'objectstack.shared':
- apps/console/src/App.tsx (line 8)
- apps/console/src/components/AppSidebar.tsx (line 38)
- apps/console/src/components/DashboardView.tsx (line 9)
- apps/console/src/components/PageView.tsx (line 9)
- apps/console/src/mocks/browser.ts (line 12)
- apps/console/src/mocks/server.ts (line 13)
- apps/console/src/tests/ConsoleApp.test.tsx (line 10)
- apps/console/src/tests/PageView.test.tsx (line 8)
For consistency, either all these files should import from 'objectstack.config' (if they need the full runtime configuration including plugins and datasources), or this test should revert to importing from 'objectstack.shared' (if only the app/object definitions are needed). Note that 'objectstack.config' includes additional runtime properties (plugins, datasources, build, dev, deploy) that 'objectstack.shared' does not have.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.