Skip to content

[WIP] Update CI workflow for better efficiency #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hotlong merged 2 commits into from
Feb 5, 2026
Merged

[WIP] Update CI workflow for better efficiency #387

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60dbcc0
Initial plan
Copilot Feb 5, 2026
4d141a1
Fix SpecCompliance test to import from objectstack.config
Copilot Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/console/src/__tests__/SpecCompliance.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

import { describe, it, expect } from 'vitest';
import appConfig from '../../objectstack.shared';
import appConfig from '../../objectstack.config';
Copy link

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title mentions "Update CI workflow for better efficiency" but the actual changes only modify an import statement in a test file. There are no changes to any CI workflow files in .github/workflows/. Either the PR title should be updated to reflect the actual changes (e.g., "Fix SpecCompliance test import") or the intended CI workflow changes are missing from this PR.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import change creates an inconsistency in the codebase. While this test now imports from 'objectstack.config', there are at least 7 other files in the same app that still import from 'objectstack.shared':

  • apps/console/src/App.tsx (line 8)
  • apps/console/src/components/AppSidebar.tsx (line 38)
  • apps/console/src/components/DashboardView.tsx (line 9)
  • apps/console/src/components/PageView.tsx (line 9)
  • apps/console/src/mocks/browser.ts (line 12)
  • apps/console/src/mocks/server.ts (line 13)
  • apps/console/src/tests/ConsoleApp.test.tsx (line 10)
  • apps/console/src/tests/PageView.test.tsx (line 8)

For consistency, either all these files should import from 'objectstack.config' (if they need the full runtime configuration including plugins and datasources), or this test should revert to importing from 'objectstack.shared' (if only the app/object definitions are needed). Note that 'objectstack.config' includes additional runtime properties (plugins, datasources, build, dev, deploy) that 'objectstack.shared' does not have.

Copilot uses AI. Check for mistakes.

/**
* Spec Compliance Tests
Expand Down
Loading