fix(permissions): type-check its tests (#4040 tranche 1) by yinlianghui · Pull Request #4287 · objectstack-ai/objectui

yinlianghui · 2026-08-11T11:10:41Z

Part of #4040 — tranche 1, package 5 of 5. Substituted for plugin-grid, which stopped on a public-type question and is filed as #4277. One package per PR, per the 裁决 on objectstack-ai/objectstack#4118 (PM, 2026-08-03):

小包先行,core(80)/react(76)最后;
每包独立 PR;守卫类 PR 必须附 pre-fix 代码报红的运行记录(判别力证明,防「绿灯守卫从未真正跑过」——已发现的第三种失败模式:tsconfig.test.json 存在但没人跑);
TEST_DEBT 条目随包清零,只减不增。

Measured before / after

	errors
declared in `TEST_DEBT`	5 (code-tier)
measured on this branch's base (`90e792e11`), template as-is	26 — 21 config-tier + 5 code-tier
after	0

The 21 are TS2304: Cannot find name 'global' across the two MePermissionsProvider
suites, which stub the fetch seam as global.fetch = vi.fn(). global is an ambient
declaration, so types: ["node"] in the test project resolves all 21 — config-tier, exactly
the class the card's template section is about, and it leaves the declared 5 intact:

src/__tests__/evaluator.test.ts(16,7): error TS2741: Property 'permissions' is missing in type '{ name: string; label: string; }' but required in type 'RoleDefinition'.
src/__tests__/evaluator.test.ts(17,7): error TS2741: ... '{ name: string; label: string; inherits: string[]; }' ...
src/__tests__/evaluator.test.ts(18,7): error TS2741: ...
src/__tests__/store.test.ts(14,3): error TS2741: ...
src/__tests__/store.test.ts(15,3): error TS2741: ...

The five code-tier errors: incomplete fixtures, not a wrong type

RoleDefinition.permissions (packages/types/src/permissions.ts:50) is a required
ObjectLevelPermission[] carrying a role's direct object grants. Five fixtures declared
RoleDefinition without it.

The type is not the problem, so it was not touched: every grant these cases exercise arrives
through the ObjectPermissionConfig[] beside the roles, keyed by object, and what the role
fixtures pin is identity and inheritance — which is all resolveRoles
(src/evaluator.ts:92) reads. permissions: [] is therefore the accurate value for these
roles rather than padding added to satisfy a compiler, and the cases assert exactly what
they did before.

Discrimination proof — the new project can fail

No guard test's assertions changed here, so the thing that needs its discrimination shown is
the new project itself. Appending a provably-false line to src/__tests__/store.test.ts:

$ npx tsc -p tsconfig.test.json
src/__tests__/store.test.ts(101,7): error TS2322: Type 'string' is not assignable to type 'number'.
EXIT:2

Reverted immediately; the probe is not in the diff.

Filed, not fixed

RoleDefinition.permissions is required and read by nothing in this repository — the
evaluator, store and provider all take RoleDefinition[] and use only name/inherits.
That is an observation about a dormant declared surface, not a defect a user meets, so it is
filed separately rather than resolved here; changing it either way is a public-type call.

Verification

$ pnpm --filter @object-ui/permissions type-check
> tsc --noEmit && tsc -p tsconfig.test.json
EXIT:0

$ pnpm exec vitest run packages/permissions --maxWorkers=2      # from the repo root, per objectui#3378
 Test Files  4 passed (4)
      Tests  52 passed (52)

$ node scripts/check-type-check-coverage.mjs
type-check coverage: 43/45 via `type-check`, 1 via their own build, 0 known-broken (0 errors outstanding), 1 not compiled.
test type-check coverage: 26/40 packages compile their tests, 14 declared debt (235 errors outstanding), 10 with a narrow type-assertion project.

TEST_DEBT shrinks by exactly this package's line; no other entry is touched.

Generated by Claude Code

…4040) `packages/permissions` gains a `tsconfig.test.json` on the objectui#3032 template, chained from its `type-check` script, so all four test files are compiled. All five declared code-tier errors were the same TS2741: fixtures annotated `RoleDefinition` while omitting its required `permissions`. The empty array they gain is accurate rather than padding — those roles grant nothing directly, and every grant the cases exercise arrives through the `ObjectPermissionConfig[]` beside them. A further 21 errors were config-tier (TS2304 on the Node `global` the provider suites stub `fetch` through), resolved by `types: ["node"]`. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017Qqyix2QcnpUC9XeYVDzx3

vercel · 2026-08-11T11:10:47Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Aug 11, 2026 11:10am

github-actions · 2026-08-11T11:14:27Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	28.9 KB	350 KB
Entry file	`index-gOolFs_6.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	8.88KB	3.25KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	22.10KB	4.37KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	18.13KB	5.39KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.64KB	2.21KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	35.76KB	9.11KB
auth (createAuthenticatedFetch.js)	4.37KB	1.69KB
auth (index.js)	2.35KB	1.07KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.91KB	0.87KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	26.07KB	7.56KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	6.49KB	2.64KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.65KB	0.73KB
collaboration (useCollaborationTranslation.js)	6.05KB	2.52KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	488.62KB	108.26KB
core (index.js)	3.04KB	1.15KB
create-plugin (index.js)	10.08KB	3.26KB
data-objectstack (index.js)	150.04KB	39.79KB
fields (index.js)	228.45KB	56.62KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.65KB	1.06KB
i18n (pickLocalized.js)	1.70KB	0.83KB
i18n (provider.js)	16.38KB	5.47KB
i18n (useObjectLabel.js)	27.59KB	6.63KB
i18n (useSafeTranslation.js)	4.52KB	1.96KB
layout (index.js)	38.98KB	10.85KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	4.32KB	1.64KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	8.75KB	3.06KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.67KB	1.12KB
permissions (evaluator.js)	4.41KB	1.44KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.55KB	0.71KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	45.23KB	12.45KB
plugin-charts (index.js)	61.73KB	17.54KB
plugin-chatbot (index.js)	180.33KB	42.79KB
plugin-dashboard (index.js)	118.79KB	30.79KB
plugin-designer (index.js)	210.91KB	42.67KB
plugin-detail (index.js)	238.88KB	59.71KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	114.58KB	27.68KB
plugin-gantt (index.js)	164.14KB	39.98KB
plugin-grid (index.js)	187.97KB	49.90KB
plugin-kanban (index.js)	48.60KB	13.41KB
plugin-list (index.js)	109.18KB	26.48KB
plugin-map (index.js)	17.00KB	5.32KB
plugin-markdown (index.js)	13.72KB	4.69KB
plugin-report (index.js)	40.60KB	10.58KB
plugin-timeline (index.js)	26.21KB	7.52KB
plugin-tree (index.js)	8.50KB	2.88KB
plugin-view (index.js)	84.03KB	20.55KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.67KB	2.37KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	23.71KB	7.96KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.23KB	0.66KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	4.47KB	2.03KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (dashboard-filter-alias.js)	6.23KB	2.74KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.87KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (http-retry.js)	4.32KB	2.02KB
types (index.js)	3.05KB	1.52KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	2.59KB	1.31KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.05KB	1.93KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	3.40KB	1.71KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

github-actions Bot added dependencies tests labels Aug 11, 2026

yinlianghui mentioned this pull request Aug 11, 2026

RoleDefinition.permissions is required and read by nothing — every consumer uses only name/inherits #4288

Closed

yinlianghui marked this pull request as ready for review August 11, 2026 11:22

yinlianghui added this pull request to the merge queue Aug 11, 2026

yinlianghui mentioned this pull request Aug 11, 2026

[P2] objectui: every package type-checks its tests or declares why not — and guards must prove they can fail (measured: 355 errors across 19 packages) #4040

Open

Merged via the queue into main with commit 721338d Aug 11, 2026
21 checks passed

yinlianghui deleted the claude/issue-4040-permissions branch August 11, 2026 11:28

Navigation Menu

Uh oh!

fix(permissions): type-check its tests (#4040 tranche 1) - #4287

fix(permissions): type-check its tests (#4040 tranche 1)#4287
yinlianghui merged 1 commit into
mainfrom
claude/issue-4040-permissions

yinlianghui commented Aug 11, 2026

Uh oh!

vercel Bot commented Aug 11, 2026

Uh oh!

github-actions Bot commented Aug 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

yinlianghui commented Aug 11, 2026

Measured before / after

The five code-tier errors: incomplete fixtures, not a wrong type

Discrimination proof — the new project can fail

Filed, not fixed

Verification

Uh oh!

vercel Bot commented Aug 11, 2026

Uh oh!

github-actions Bot commented Aug 11, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants