test(plugin-dashboard): close DatasetWidget's dimension-metadata network escape - #5300
Merged
os-support-ai merged 3 commits intoAug 19, 2026
Merged
Conversation
…ork escape (#5280) DatasetWidget.test.tsx's dimension-metadata probe (useDatasetDimensionMeta's apiFetch ?? fetch fallback) escaped to the real network — 5 live connection attempts per run, best-effort-swallowed so all 52 tests stayed green. Same root cause as #5225 (packages/plugin-report); ports the same fix shape from its reference PR #5283: a recording double answers the metadata route with an option-free payload, afterEach fails on any non-metadata escape, and three new tests pin the probe's own request shape. cleanup() runs before vi.unstubAllGlobals() in the same afterEach to avoid the reverse-registration flake #5225 measured (1/6 leaked attempts). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RV6yuVCxymHYE16PL9vQkE
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RV6yuVCxymHYE16PL9vQkE
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This was referenced Aug 19, 2026
os-support-ai
marked this pull request as ready for review
August 19, 2026 12:10
os-support-ai
deleted the
claude/issue-5280-dataset-widget-network-escape
branch
August 19, 2026 12:11
os-support-ai
pushed a commit
that referenced
this pull request
Aug 19, 2026
…data network escape (#5299) DashboardGridLayout.datasetPath.test.tsx's 'options.data provider widget' negative-control test made a real network call — ECONNREFUSED on port 3000, 1 attempt per isolated run, best-effort-swallowed so all 13 tests stayed green. `-t` bisected across all 13 cases in isolation: only this one test escapes (3/3); the two #4613 legacy-retired-widget candidates the card named do NOT escape alone (0/1 each), so useDatasetDimensionMeta's `!object` guard was never the site, as the card's own re-derived reading suspected. Root cause: the options.data.provider:'object' widget maps to component type `object-chart`, whose ObjectChart.tsx still carries its own inline `apiFetch ?? fetch` category-color probe (the ORIGINAL #4106 defect site, never migrated to the useDatasetDimensionMeta hook #4389 extracted for the dataset-bound path). With no SchemaRendererProvider in this file's render tree, that probe degrades to the real global `fetch`. Ports the same fix shape #5225's reference PR #5283 established and #5280 (PR #5300) ported: a recording double answers the metadata route, afterEach fails on any non-metadata escape, and cleanup() runs before vi.unstubAllGlobals() in the same afterEach to avoid the reverse-registration flake #5280 measured. One new pin test asserts the probe's own request shape — exactly one call to /api/v1/meta/object/invoices. Claude-Session: https://claude.ai/code/session_01RV6yuVCxymHYE16PL9vQkE
os-support-ai
pushed a commit
that referenced
this pull request
Aug 19, 2026
…t-only (#5299) Empty-frontmatter changeset, matching #5280's port (#5300) — no published behaviour changes. Claude-Session: https://claude.ai/code/session_01RV6yuVCxymHYE16PL9vQkE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5280
What
DatasetWidget.test.tsx's dimension-metadata probe —useDatasetDimensionMeta'sapiFetch ?? fetchfallback (packages/react/src/hooks/useDatasetDimensionLabels.ts), reached whenever a mockedqueryDatasetresult carriesobject— escaped to the real network under happy-dom (default document URLhttp://localhost:3000). Same root cause as #5225 (packages/plugin-report), confirmed by re-tracing the call chain in this package rather than assumed:DatasetWidget→useDatasetDimensionMeta→loadDimensionFieldMeta→GET /api/v1/meta/object/{object name}.Ports the exact fix shape #5225's reference PR (#5283,
DatasetReportRenderer.test.tsx) established: a recording double answers the metadata route with an option-free payload (byte-identical to what the failed read used to produce, so no pre-existing assertion changes meaning), records every URL, andafterEachfails on any non-metadata escape instead of silently swallowing it — not a blanket network stub.cleanup()runs beforevi.unstubAllGlobals()in the sameafterEach, avoiding the reverse-registration-order flake #5225 measured (1 leaked attempt in 6 runs from vitest's LIFOafterEachordering).File surface:
packages/plugin-dashboard/src/__tests__/DatasetWidget.test.tsxonly, plus a changeset. No product code changed.Measured — my own numbers, re-derived on current
origin/mainper the dispatch note (the package moved minutes before this card started, PR #5207)Before (baseline run at branch point,
95cf24168):No
invoicesrequest came from this file — that line in the issue's original capture does not reproduce fromDatasetWidget.test.tsx; filed separately as #5299 (see below).After (post-merge HEAD
6c4c090e6, 8 consecutive isolated runs + re-confirmed at the final head):All 52 pre-existing tests pass, unchanged in behaviour — none of them depended on the swallowed failure. 3 new tests pin the probe's own request shape (which object, exactly once, over the metadata route; no probe when no
object; the resolved document actually reaching a rendered cell — a success path that had never once executed while the request always failed).Reverse verification
Predicted: reverting the test file to its pre-fix (
origin/main) content restores the 5-attempt/10-line escape and drops the pin tests (55 to 52), with the pre-existing 52 staying green throughout (this defect class swallows a side effect, not an assertion — the observables are the connection count and the pins' presence, not red/green).Observed (committed the fix first, then
git checkout origin/main -- {path}, ran, thengit checkout HEAD -- {path}to restore):Matches the prediction exactly.
An adjacent finding, filed separately — not fixed here
Running the whole package (
pnpm exec vitest run packages/plugin-dashboard) after this fix still shows an intermittent 1-attempt residual, confirmed independent of this file (present/absent withDatasetWidget.test.tsxremoved from the directory entirely). Bisected toDashboardGridLayout.datasetPath.test.tsx, which reproduces 3/3 in isolation and most likely explains the stray "invoices" request in #5280's original capture. Out of this card's file surface (and #5264 is in flight in this same package) — filed as #5299.Verification
pnpm --filter '@object-ui/plugin-dashboard' type-check— pass (re-run at post-merge HEAD)pnpm --filter '@object-ui/plugin-dashboard' lint— pass, 0 errors (317 pre-existing warnings, none in the touched file's new lines)node scripts/check-control-bytes.mjs— passnode scripts/check-changeset-presence.mjs— pass (empty-frontmatter changeset declared)pnpm exec vitest run packages/plugin-dashboard/src/__tests__/DatasetWidget.test.tsx(repo root) — 8 consecutive clean runs, 0 ECONNREFUSED, 55/55 passedpnpm exec vitest run packages/plugin-dashboard(whole package, repo root) — 64 files / 581 tests passedMerged
origin/main(7260a1ed4, unrelated eslint-rules commit) before opening this PR — no conflicts. Final head:6c4c090e6.Generated by Claude Code