fix(examples/crm): remove as any cast from objectstack.config.ts#581
Merged
fix(examples/crm): remove as any cast from objectstack.config.ts#581
as any cast from objectstack.config.ts#581Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…r type safety Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix type safety by removing as any from CRM config
fix(examples/crm): remove Feb 18, 2026
as any cast from objectstack.config.ts
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a type-safety bypass in the CRM example stack configuration by deleting an unnecessary as any cast, ensuring defineStack enforces the config shape at compile time. Also updates the project roadmap to reflect completion of the task.
Changes:
- Remove trailing
as anycast fromexamples/crm/objectstack.config.tssodefineStacktype-checking is enforced. - Mark the corresponding roadmap item as completed under P0.1.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| examples/crm/objectstack.config.ts | Drops the as any cast at the defineStack call site to restore compile-time validation. |
| ROADMAP.md | Adds a checked roadmap entry indicating the CRM config type-safety fix is complete. |
Copilot AI
added a commit
that referenced
this pull request
Feb 18, 2026
Add back the CRM type safety line from PR #581 that was merged into main while keeping our MSW cleanup item marked as completed. Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
examples/crm/objectstack.config.tsended withas any, bypassingdefineStacktype checking entirely. The config is already fully compliant with the expected type — the cast was unnecessary.examples/crm/objectstack.config.ts:} as any)→})ROADMAP.md: Mark item complete under P0.1All 4383 tests pass. No type errors in the config after removal.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.