Skip to content

refactor: migrate msw-todo config to standard apps/manifest structure#582

Merged
hotlong merged 4 commits intomainfrom
copilot/refactor-msw-todo-configuration
Feb 18, 2026
Merged

refactor: migrate msw-todo config to standard apps/manifest structure#582
hotlong merged 4 commits intomainfrom
copilot/refactor-msw-todo-configuration

Conversation

Copy link
Contributor

Copilot AI commented Feb 18, 2026

  • Analyze current msw-todo config vs standard format (todo, kitchen-sink, crm examples)
  • Refactor examples/msw-todo/objectstack.config.ts to standard apps: [App.create(...)] + manifest structure
  • Update examples/msw-todo/README.md code snippets to reflect new config structure
  • Update ROADMAP.md to mark the related item as completed
  • Verify build succeeds for msw-todo example (tsc + vite build pass)
  • Run CodeQL security scan — no alerts found
  • Resolve merge conflict in ROADMAP.md (add back CRM type safety line from PR fix(examples/crm): remove as any cast from objectstack.config.ts #581)
Original prompt

This section details on the original issue you should resolve

<issue_title>[P1] msw-todo 配置重构为标准 apps 和 manifest 结构</issue_title>
<issue_description>examples/msw-todo/objectstack.config.ts 并未采用 ObjectStackDefinition 标准格式,而是将 app 级属性平铺至 stack 顶层。

风险

  • 配置不规范,影响示例示范和类型推断。
  • IDE/codegen 工具等无法识别结构。

修复建议

  • 定义标准 manifest 字段,所有 app 级参数放入 apps: [App.create(...)]。
  • 配置拆分为 manifest/object/app,具体参见其他 example 规范写法。

  • 修复完成需运行 test,确保 roadmap 相关已同步更新。</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@vercel
Copy link

vercel bot commented Feb 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
objectui Ready Ready Preview, Comment Feb 18, 2026 6:55am
objectui-demo Ready Ready Preview, Comment Feb 18, 2026 6:55am
objectui-storybook Ready Ready Preview, Comment Feb 18, 2026 6:55am

Request Review

- Move app-level properties (name, label, description, icon, branding, navigation) into apps: [App.create({...})]
- Add manifest section with id, version, type, name, description
- Import App from @objectstack/spec/ui
- Update README.md code snippets to reflect new standard format
- Mark ROADMAP.md item as completed

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot AI changed the title [WIP] Refactor msw-todo configuration to standard apps and manifest structure refactor: migrate msw-todo config to standard apps/manifest structure Feb 18, 2026
Copilot AI requested a review from hotlong February 18, 2026 05:07
@hotlong hotlong marked this pull request as ready for review February 18, 2026 05:15
Copilot AI review requested due to automatic review settings February 18, 2026 05:15
@hotlong
Copy link
Contributor

hotlong commented Feb 18, 2026

@copilot 修正合并冲突

Add back the CRM type safety line from PR #581 that was merged into main
while keeping our MSW cleanup item marked as completed.

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 18, 2026

@copilot 修正合并冲突

Resolved in b03cbc3 — added back the CRM type safety line from PR #581 that was merged into main, while keeping the MSW cleanup item marked as completed.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the examples/msw-todo stack definition to match the repository’s standard ObjectStackDefinition shape by moving app-level metadata into apps: [App.create(...)] and adding a top-level manifest block, aligning this example with other example apps.

Changes:

  • Migrate examples/msw-todo/objectstack.config.ts to use apps + manifest (and import App from @objectstack/spec/ui).
  • Update the README snippet in examples/msw-todo/README.md to reflect the new config structure.
  • Mark the related roadmap task as complete in ROADMAP.md.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
examples/msw-todo/objectstack.config.ts Moves flattened app properties into apps: [App.create(...)] and adds manifest metadata.
examples/msw-todo/README.md Updates documentation snippet to show apps/manifest usage.
ROADMAP.md Marks the MSW config cleanup item as done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P1] msw-todo 配置重构为标准 apps 和 manifest 结构

3 participants