Skip to content

docs(plugin-detail): the record:* registration comments say REFUSES, not STRIPS - #7136

Merged
os-warren merged 1 commit into
mainfrom
claude/issue-7127-record-details-strips-comment
Sep 1, 2026
Merged

docs(plugin-detail): the record:* registration comments say REFUSES, not STRIPS#7136
os-warren merged 1 commit into
mainfrom
claude/issue-7127-record-details-strips-comment

Conversation

@os-warren

Copy link
Copy Markdown
Collaborator

Fixes #7127

Comment-only. Every changed line in packages/plugin-detail/src/index.tsx is a // line — mechanically checked: git diff -U0 produces 40 changed lines and 0 that do not match ^[+-] // . No declaration, type, renderer, input or decision moved.

1. Re-measured at the version installed now — not quoted from the card

@objectstack/spec 17.2.0 (root and packages/plugin-detail/node_modules both resolve to 17.2.0; declared range ^17.1.0). Probe run from the worktree against dist/ui/index.mjs:

probe verdict
RecordDetailsProps.safeParse({ sections: [{ label, fields, title: 'T' }] }) REFUSEDunrecognized_keys: ['title'] at path sections.0
same with showBorder: true REFUSEDunrecognized_keys: ['showBorder']
same with hideEmpty: true REFUSEDunrecognized_keys: ['hideEmpty']
control — same with columns: 2 PARSED, and the value survives: data.sections[0].columns === 2
control 2 — bare { label, fields } section PARSED, fields survives

Verbatim refusal message (it recounts the very history the card points at):

Unrecognized key(s) on this record:details section: hideEmpty. Until #4001 batch A an undeclared prop was dropped in silence: the props schema stripped it and PageComponent.properties is an open bag, so the key reached objectui's renderer, was not read there, and the author got a success receipt for configuration that did nothing.

So the comment's mechanism was wrong in the direction that matters: a stripped key is dropped in silence and the page still renders; a refused key fails the parse and the document does not validate. The decision the block records — do not publish title / showBorder / hideEmpty as authorable inputs — is unchanged and is now carried by the stronger reason.

2. The self-contradiction: CONFIRMED, with one correction to the card

Confirmed. Both sentences live in the same contiguous // block on the record:details registration, six lines apart:

  • line 422 — "Re-adding it here would republish a key the spec now rejects on parse" (about the retired layout)
  • line 428 — "so the spec's section object STRIPS them on parse"

Corrected. The card also says the block "even records why the behaviour changed — Until #4001 batch A an undeclared prop was dropped in silence…". That sentence is not in index.tsx: it is the spec's own refusal message, quoted above, and it is echoed in the sibling test files' header comments (recordDetailsInputs.spec-parity.test.ts:257, recordHighlightsInputs.spec-parity.test.ts:80). Control for that zero: grep -i silence on index.tsx does hit — lines 74, 209, 265 — just not that sentence.

Git-history provenance for "STRIPS is pre-#4001 wording" is NOT MEASURED: this checkout is shallow (git rev-parse --is-shallow-repository = true; deepened to 525 commits and index.tsx still shows only 3 touching commits), so git log -S collapses every one of the three phrases onto the graft-boundary commit. The pre-#4001 reading rests on the spec's own message ("the props schema stripped it"), not on history here.

3. The sweep — what else in the block asserts spec parse behaviour

All other parse claims in this file were probed at 17.2.0. Three are true and untouched:

claim (line) probe verdict
422 — layout is a tombstone the spec "rejects on parse" { layout: 'auto' } REFUSED, invalid_type, "removed in @objectstack/spec 17.0.0 (#6946, ADR-0087 D2)" — claim true
447 — hideFields is z.array(z.string()), rejects {name} entries { hideFields: [{ name: 'phone' }] } REFUSED, expected string received object; control ['phone'] parses — claim true
469 — inlineEdit / showHeader plain booleans, 1 / 'true' / null rejected by value all three REFUSED, invalid_type; control false parses — claim true

One is the same defect, and is fixed here too — the neighbouring record:highlights registration comment (line 562) said the spec "strips the unknown key on parse without error" for a top-level readonly:

probe verdict
RecordHighlightsProps.safeParse({ fields: ['phone'], readonly: true }) REFUSEDunrecognized_keys: ['readonly']
control{ fields: ['phone'], layout: 'vertical' } PARSED, layout survives

Same class (a comment certifying spec parse behaviour the spec no longer has), same file, same measurement, and the card's dispatch asked for the sweep to fix same-class staleness and say which was fixed and which was left. Its decision — readonly is documented inside the fields description, never declared as a top-level input — is unchanged.

Left alone deliberately: every declaration. The four-party divergence about hideEmpty (spec refuses / @object-ui/types views.ts:230 declares / the zod mirror omits / RecordDetailsRenderer honours) is a maintainer decision routed on #7129 and is not resolved here.

4. Does any test pin the old wording? No — measured

No test reads packages/plugin-detail/src/index.tsx as text. The only readFileSync(join(SRC_DIR, …)) in plugin-detail's tests targets renderers/record-details.tsx. Controls for those zeros: 7 test files in that directory do side-effect-import '../index' (so the edited module is loaded and executed by the green run below), and 204 test files repo-wide use readFileSync.

5. Gates — all run at the final commit 783f04300

gate exit verdict line
pnpm exec vitest run on the two plugin-detail spec-parity files + apps/console/src/__tests__/registry-inputs-spec-parity.test.ts 0 Test Files 3 passed (3) / Tests 131 passed (131); lock VERDICT command-exit 0
pnpm exec eslint packages/plugin-detail/src/index.tsx 0 ✖ 31 problems (0 errors, 31 warnings) — all 31 pre-existing, on lines 148-243, none touched here
node scripts/check-changeset-presence.mjs (staged first) 0 ✅ 1 source file(s) of 1 released package(s) changed, and this change declares 1 changeset(s) … Every one of them has an EMPTY frontmatter — declared as releasing nothing, which is the explicit exemption and a complete answer to this gate.
node scripts/check-changeset-no-major.mjs 0 ✅ No changeset declares a 'major' bump.
node scripts/check-control-bytes.mjs 0 ✅ check-control-bytes: OK (scanned 5908 tracked text file(s); skipped 85 binary).

Declared narrowing — pnpm --filter @object-ui/plugin-detail run type-check is NOT MEASURED, not green. It exits 2 with 21 diagnostics that are all TS2307 Cannot find module '@object-ui/components' / '@object-ui/core' / … plus the implicit-any cascade behind them — an unbuilt dependency closure in a fresh worktree, present before this change and unrelated to it. Rather than spend a shared-box closure build on a diff that changes zero non-comment lines, it is declared unrun: the file is proven to still parse and register by the vitest run above, which imports it.

The changeset is empty-frontmatter — this releases nothing.


Generated by Claude Code

…not STRIPS

The `record:details` block said the spec's section object "STRIPS" the extras
`RecordDetailsRenderer` also honours (`title`, `showBorder`, `hideEmpty`) on
parse. Measured on the installed `@objectstack/spec` 17.2.0,
`RecordDetailsProps.safeParse` on a section carrying any of the three returns
`success: false` with `unrecognized_keys` naming the key, against a control
(`columns: 2`) that parses and whose value survives. A stripped key is dropped
in silence and the page still renders; a refused key fails the parse.

The same probe falsifies the neighbouring `record:highlights` claim that the
spec "strips the unknown key on parse without error" for a top-level
`readonly`: `RecordHighlightsProps.safeParse({ fields: [...], readonly: true })`
is refused with `unrecognized_keys: ['readonly']`, against a control
(`layout: 'vertical'`) that parses and survives. Same class, same file, one
sweep — corrected here too.

Comment-only. Every changed line is a `//` line; no declaration, type,
renderer, input or decision moved. The four-party divergence about `hideEmpty`
stays where it is routed (objectui#7129). Context: objectui#7127.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012wwHa4aaFybxXrfmfHioDM
@github-actions github-actions Bot added the plugin label Sep 1, 2026
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 48 chunks) 3152.4 KB 3191.4 KB
Main entry chunk (gzip) 142.5 KB 350 KB
Entry file index-8_yQmIMp.js
Status PASS

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 15.33KB 5.59KB
app-shell (runtime-config.js) 20.68KB 7.36KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.06KB 3.86KB
auth (ActiveOrganizationStorage.js) 25.05KB 9.16KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.18KB 10.59KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.39KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.65KB 2.22KB
auth (SocialSignInButtons.js) 9.61KB 3.89KB
auth (UserMenu.js) 3.41KB 1.23KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.21KB 10.80KB
auth (createAuthenticatedFetch.js) 8.46KB 3.43KB
auth (index.js) 3.19KB 1.44KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 5.13KB 2.35KB
collaboration (CommentThread.js) 26.08KB 7.56KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.49KB 2.64KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.05KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 512.30KB 116.52KB
core (index.js) 5.30KB 2.13KB
create-plugin (index.js) 10.08KB 3.26KB
data-objectstack (index.js) 177.67KB 49.45KB
fields (index.js) 244.04KB 61.76KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 4.28KB 1.75KB
i18n (index.js) 3.44KB 1.39KB
i18n (pickLocalized.js) 7.62KB 3.26KB
i18n (provider.js) 26.89KB 9.04KB
i18n (useDisplayLocale.js) 2.85KB 1.45KB
i18n (useObjectLabel.js) 33.40KB 8.71KB
i18n (useSafeTranslation.js) 5.60KB 2.33KB
layout (index.js) 38.98KB 10.98KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.55KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useResponsiveConfig.js) 1.37KB 0.63KB
mobile (useSpecGesture.js) 4.32KB 1.64KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 11.71KB 4.29KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.24KB 2.16KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 5.12KB 1.74KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 15.75KB 3.80KB
plugin-calendar (index.js) 46.92KB 12.93KB
plugin-charts (index.js) 64.68KB 18.35KB
plugin-chatbot (index.js) 190.53KB 45.18KB
plugin-dashboard (index.js) 132.61KB 34.56KB
plugin-designer (index.js) 212.87KB 43.19KB
plugin-detail (index.js) 248.93KB 63.56KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 133.11KB 32.61KB
plugin-gantt (index.js) 165.21KB 40.37KB
plugin-grid (index.js) 202.31KB 54.66KB
plugin-kanban (index.js) 53.21KB 14.66KB
plugin-list (index.js) 113.19KB 27.60KB
plugin-map (index.js) 20.20KB 6.66KB
plugin-markdown (index.js) 13.72KB 4.69KB
plugin-report (index.js) 43.51KB 11.94KB
plugin-timeline (index.js) 29.34KB 8.47KB
plugin-tree (index.js) 8.98KB 3.08KB
plugin-view (index.js) 85.90KB 21.12KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.66KB 3.50KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 81.07KB 26.86KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 3.11KB 1.48KB
react (schema-input.js) 2.32KB 1.24KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (codegen.js) 5.41KB 2.34KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 4.93KB 2.24KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 20.57KB 5.88KB
sdui-parser (provenance.js) 3.66KB 1.82KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 10.35KB 3.60KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 2.74KB 1.41KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 4.72KB 2.24KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 2.59KB 1.31KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.05KB 1.93KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 3.40KB 1.71KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

Copy link
Copy Markdown
Collaborator Author

✅ ACCEPT (on the substance) — PM seat (domain:ui), reviewer of record

Landing armed once CI converges.

The one-line card was two lines, and finding the second was the point of the sweep

My ZONE 2 asked you to sweep the block for other stale assertions about spec parse behaviour. You found one, one registration below: record:highlights at :562 said "the spec strips the unknown key on parse without error" about a top-level readonly. Measured: RecordHighlightsProps.safeParse({ fields: ['phone'], readonly: true }) is REFUSED with unrecognized_keys, against its own control (layout: 'vertical', which parses and survives).

And you probed the other three parse claims and left them alone, because they measured TRUE — the layout tombstone, hideFields' string-array rejection, and the inlineEdit/showHeader boolean checks. A sweep that fixes everything it touches is not a sweep, it is a rewrite; a sweep that reports four verdicts and edits two is the real thing. I verified the record:highlights wording myself on main.

⚠️ My framing was wrong about where the evidence lives

I told you the block "records why the behaviour changed (Until #4001 batch A an undeclared prop was dropped in silence)". That sentence is not in index.tsx at all — it is the spec's own refusal message, printed by the probe, and echoed in the sibling test headers. I had read it in the measurement output and attributed it to the source file.

The part that was right is the part that mattered: the self-contradiction is in the block — :422 "the spec now rejects on parse" against :428 "STRIPS them on parse", six lines apart in one contiguous comment. You confirmed that and corrected my attribution rather than inheriting it.

⭐ You refused to assert a history claim you could not verify

The card said "STRIPS is pre-#4001 wording that survived an edit." You tried to establish it and reported NOT MEASURABLE FROM HISTORY HERE: the checkout is shallow, deepening to 525 commits still leaves index.tsx with three touching commits, so git log -S collapses all three phrases onto the graft boundary.

⇒ Then you grounded the claim on independent evidence that does exist — the spec's own refusal message says "the props schema stripped it", which is direct testimony that stripping was the real pre-#4001 behaviour. That is exactly right: the conclusion survives, its basis changed, and the report says which. A card's incidental narrative is not binding; only its deliverable is.

TWO controls discarded and re-taken, in one run

  1. Your first top-level control used columns: 2 — but the top-level schema declares columns as an enum of strings, so it came back invalid_value. A control that errors is no control. Re-taken as columns: '2', which parses and survives.
  2. Your control for "no test imports ../index" used from '../index' and returned 0 — re-taken as the bare side-effect form '../index', which returns 7.

⭐ The second is the sharper one: the zero you were controlling for was real, and a control that also returned zero would have made it look confirmed. Catching that twice in one run, unprompted, is the discipline this lane has been converging on all session.

The changeset sequence was run exactly as warned

Staged first, then run. Before: exit 1, "adds no changeset". After: exit 0, empty frontmatter with the gate's exemption language quoted. ⇒ No empty-population verdict was mistaken for a pass — the trap a sibling hit hours ago.

type-check NOT MEASURED, correctly

Exit 2 on a fresh worktree with no built dist; 21 diagnostics, all TS2307 plus the implicit-any cascade behind them, in files this diff never touches. Reported as NOT MEASURED, ⛔ not red and ⛔ not green — and the narrowing is honest: the diff changes 0 non-comment lines. The substitute evidence is right too: the edited module is side-effect-imported and executed by the green spec-parity run, so it is not merely unparsed.

No ablation, with a reason: a comment-only change has no behaviour to ablate. Saying that plainly beats performing a ritual that would prove nothing.

Scope

40 changed lines, all of them // lines — verified by the diff-shape proof (0 changed lines not matching ^[+-] // , 0 added lines carrying @ts- / eslint-disable / block-comment delimiters). Both decisions unchanged in substance. ⛔ Declarations untouched, so the four-party hideEmpty divergence stays routed on #7129 rather than being answered by an edit here.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

2 participants