Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .changeset/7319-dead-schemarenderer-retired.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
---
'@object-ui/components': patch
---

Delete the second, dead `SchemaRenderer` in `packages/components/src` (objectui#7319).

`packages/components/src/SchemaRenderer.tsx` was a 28-line component carrying the same
export name as the real renderer in `packages/react/src/SchemaRenderer.tsx`. Nothing
reached it: it is absent from the package barrel, no file in the repo imports it by any
form, and the package's `exports` map has no subpath that resolves to it.

**No behaviour changes.** The file was never in the runtime bundle — two markers unique to
it appear in zero `dist/` files, while controls for barrel-exported symbols appear in four
each. Its only shipped footprint was a stray types-only `dist/SchemaRenderer.d.ts` with no
runtime module behind it, reachable through no specifier; the published tarball loses that
file, and no importable surface changes in either direction. Hence a patch, not a minor.

**Why deleting beat keeping.** The copy is a trap, which is what the card's triage asked
whoever took it to settle. It evaluates no predicate at all: of the real renderer's six
visibility legs (`visibleWhen` / `visible` / `visibleOn` / `visibility` / `hidden` /
`hiddenOn`) it consults exactly one, `hidden`, and by bare truthiness rather than
evaluation — so a node declaring `hiddenOn` is never hidden, and the two enablement legs
(`disabled` / `disabledOn`) are not read at all. It then spreads `{...schema}` raw, so
`disabled` would reach the widget as an unevaluated value, which is the precise inverse of
the real renderer's contract: evaluate the predicate, strip the raw key, forward only the
verdict.
28 changes: 0 additions & 28 deletions packages/components/src/SchemaRenderer.tsx

This file was deleted.

Loading