docs(check-skill-examples): drop the stale zero-jsonc-fences claim - #7631
Merged
Conversation
`parseJsonFence`'s docblock said "There are zero `jsonc` fences in the corpus today" as the reason the dialect is recognised. That stopped being true at PR #7473 (16 comment-carrying fences retagged `jsonc`) and PR #7608 moved it further (41 `json` / 29 `jsonc` today, confirmed with `node scripts/check-skill-examples.mjs --measure`). The sentence read as "this branch has never run in anger" — the opposite of the truth, and a risk that a reader deletes or weakens the branch as dead code. Rewritten to a count-free statement, in the same convention the file's own header uses for its other counts ("Re-derive it with `--measure`"): the branch is exercised by fences already in the corpus, not merely reserved for a hypothetical one. No behaviour change. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019RfFHiRCSs3JXLK4cwcfox
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7610
parseJsonFence's docblock (inscripts/check-skill-examples.mjs) said "Thereare zero
jsoncfences in the corpus today" as the reason the dialect isrecognised. That stopped being true at PR #7473 (16 comment-carrying fences
retagged
jsonc) and PR #7608 moved it further. The sentence read as "thisbranch has never run in anger" — the opposite of the truth, and a risk that a
reader deletes or weakens the branch as dead code (filed out of scope by the
#7474 dev seat working PR #7608, whose dispatch pinned this file to its
MARKED_FLOORjson row only).Change
One sentence, no behaviour change:
Before:
After:
Went with the count-free form per the triage/dispatch preference: the
docblock's point (why the dialect is recognised, and that the branch is live)
survives without a number, and it matches the file's own convention for its
other counts elsewhere in the header ("Re-derive it with
--measure" /"Re-derive it with
pnpm check:skill-examples").Measured on this branch (same tree as
origin/mainat merge-base11edab8)with the gate's own scanner,
node scripts/check-skill-examples.mjs --measure:41
jsonand 29jsoncfences underskills/objectui— a controlgrep -c '^```jsonc'gives the same 29 but is not the measurement used.Verification
node scripts/check-skill-examples.mjs(the gate, whole corpus) — exit 0,"Every marked skill example holds up against the built types."
node scripts/check-skill-examples.mjs --self-test— exit 0, "52 cases pass"(identical case count to
origin/main).pnpm exec vitest run scripts/__tests__/check-skill-examples.test.ts scripts/__tests__/check-skill-eval-tokens.test.ts— exit 0, "Test Files 2passed (2)", "Tests 120 passed (120)".
pnpm check:control-bytes— exit 0.pnpm check:shell-escape-residue— exit 0.pnpm lint(whole repo, heap-capped) — exit 0, 47/47 tasks, pre-existingwarnings only, none touching this file.
node scripts/check-changeset-presence.mjs— "No source or publishedcontract of a released package changed in this range, so no changeset is
owed."
Scope:
scripts/check-skill-examples.mjsonly — not a governed surface here(
scripts/**), draft PR for in-seat review, ready + auto-merge by the seat.Generated by Claude Code
Generated by Claude Code