docs(plugin-form): fix bare-field visibleWhen spelling in fieldTabs example - #8023
Merged
Merged
Conversation
…xample
The fieldTabs[].visibleWhen example on the billing tab used the bare
identifier `status == "won"`. plugin-form's fieldRules engine binds the
row as `record` only (evalFieldPredicate / buildScope({ record })), so
this spelling faults with "Unknown variable: status" and fails OPEN —
the tab it is meant to hide stays visible. Rewrite both copies of the
example to the canonical `record.status == "won"`, matching PR #5758's
earlier fix to the same file's requiredWhen example.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FhBNJcLRZLe8M87VcUgpKr
github-actions
Bot
added
documentation
Contributor
Author
|
Standing-down note — Generated by Claude Code |
Contributor
✅ Console Performance Budget
The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it. 📦 Bundle Size Report
Size Limits
|
baozhoutao
marked this pull request as ready for review
September 6, 2026 10:59
baozhoutao
deleted the
claude/issue-7834-fieldtabs-visiblewhen-record
branch
September 6, 2026 11:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7834
What changed
The
fieldTabs[].visibleWhenexample in plugin-form's docs used the bareidentifier
status == "won"on thebillingtab. plugin-form'sevalFieldPredicatebinds the row scope asrecordonly(
buildScope({ record })inpackages/core/src/evaluator/fieldRules.ts),so this spelling faults with an undeclared-reference error and, per
TabbedForm.tsx, a broken predicate fails OPEN — the tab it was meant tohide stays visible. Rewrote both copies of the example to the canonical
record.status == "won":content/docs/plugins/plugin-form.mdx:173packages/plugin-form/README.md:446This is the same one-token rewrite PR #5758 made to this README's
requiredWhenexample one block earlier.Why
Docs should not teach a spelling the engine never bound. No behavior
changed; this is a two-token text fix in two doc files.
Scope
Two-token rewrite at exactly the two cited sites, per this repo's triage
ruling on #7834. Not widened into a prose-corpus pin (that is tracked
separately, per the triage boundary citing
rowPredicateCanon.schemaCatalog.test.ts:16-23); nopackages/**sourcechanged.
Generated by Claude Code