Skip to content

test(plugin-markdown): cite toc-anchor-parity instances by content, not line address - #8046

Merged
os-steve merged 1 commit into
mainfrom
claude/issue-7913-toc-anchor-cite-by-content
Sep 6, 2026
Merged

test(plugin-markdown): cite toc-anchor-parity instances by content, not line address#8046
os-steve merged 1 commit into
mainfrom
claude/issue-7913-toc-anchor-cite-by-content

Conversation

@claude

@claude claude Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Fixes #7913

Authored by the os-dev seat in session https://claude.ai/code/session_01QnpvbdoRisQdRAczkLwnf5.

The repair

toc-anchor-parity.test.tsx:136 named its case by line address:

it('resolves the anchor for ### NON_GRID_ROW_CEILING (packages/react/README.md:224)', ...

Verified on origin/main at 06761b351: the heading is now at packages/react/README.md:253, and nothing went red — the test asserts an inline string and never reads the file, so the address lived only in the name.

The address was dropped, not updated to :253. Updating it defers the rot to the next edit, which is the whole content of the card. The heading text ### NON_GRID_ROW_CEILING is already the identifying content and is already in the assertion one line below. This is the class objectui#7853 ruled on — cite the assertion by content, not by line address — with #6998, #7289 and #6548 as prior recurrences.

⭐ Five more addresses in the same file, and the bounded in-place fix

The card and triage both counted one instance in this file. There are six. LIVE_SHAPES carries a where field that line 60 interpolates straight into the test name:

it(`resolves the anchor for ${md} (${where})`, ...

so three more test names carried five more line addresses (cli.mdx:136, cli/README.md:108, cli.mdx:220, cli/README.md:112, runner.mdx:106). They were missed because a sweep anchored on the it( line cannot see a name built from data — the addresses live 16 lines above it in a fixture table.

Those five are repaired here as a bounded in-place fix: same file, same defect class, same suite, no new verification surface, and no other claim on the file. where now names the files, which is content identity; the heading text in md remains the identifying content.

⚠️ Measured, since it changes how this reads: all five were accurate today — only the card's :224 was live-stale. The defect is not that they are wrong, it is that nothing can tell you when they become wrong.

Evidence, from the rendered names at f6d3b3e:

✓ ... > resolves the anchor for ### NON_GRID_ROW_CEILING
✓ ... > resolves the anchor for ### `objectui add [component]` (content/docs/utilities/cli.mdx, packages/cli/README.md)

A comment above LIVE_SHAPES now records the convention so the class does not return to this file.

The sweep across packages/**, with a control that fires

grep -rnE "^[[:space:]]*(it|test|describe)[.a-zA-Z]*\(.*\.(md|mdx|ts|tsx|js|jsx|mjs|cjs|json|ya?ml|css|html|txt|snap|sh):[0-9]+" \
  packages --include='*.test.ts' --include='*.test.tsx' --include='*.test.mts' \
           --include='*.spec.ts' --include='*.spec.tsx'

Control: against a fixture of five known-positive shapes (single quotes, double quotes, backticks, it.each, it.skip) and two known-negatives (a bare path with no address; a version number plus a clock time) it reports 5 and 0, and in-tree it reports #7913's own instance. A zero from this regex is now a reading rather than a guess.

Result: 3 hits across 2 files, matching triage exactly — this file, plus 2 in packages/types/src/__tests__/text-value-retired-6951.test.ts. Coverage: 2352 of the 2357 files under packages/** that declare tests match those globs; the remaining 5 were swept separately and are clean. A second, name-agnostic scan (quoted addresses on non-comment lines) found the interpolated group above and nothing else in a test name.

The packages/types pair is domain:spec, so it is deliberately not in this PR — filed as #8045 for triage to route, unassigned and finding-only. Both are accurate today (layout.ts:66 really is TextSpanSchema.value), which is recorded there because triage had not checked it.

Verification — all at f6d3b3e, clean tree

Check Result
pnpm exec vitest run packages/plugin-markdown/ exit 0 — 5 files, 49 tests passed
pnpm --filter @object-ui/plugin-markdown run type-check exit 0 (after pnpm --filter '@object-ui/plugin-markdown^...' build; the file is in the program — tsc --listFiles reports it once)
check-changeset-presence exit 0 — empty frontmatter accepted as "releases nothing"
check-changeset-fixed / -no-major / -overwrite exit 0
check-control-bytes exit 0 (6457 files scanned)
check-governed-queue-guard --test NOT GOVERNED — ordinary route

⚠️ The first type-check run failed with Cannot find module '@object-ui/core' on unbuilt dependencies. That is NOT MEASURED rather than red; the row above is the run after the dependency closure was built.

Lint is a declared narrowing, not a full run. eslint --no-inline-config on the touched file: exit 0, 1 file, 0 errors, 0 warnings. Population, read from ESLint's own ignore logic rather than guessed: 4358 tracked JS/TS files it would lint. Invariance: eslint.config.js configures no project / projectService / parserOptions.project, so typescript-eslint runs without type information and each file is judged in isolation — a one-file diff cannot move the verdict on any untouched file. The repo-wide scan belongs to CI.

Notes

  • No skip-changeset label: this diff is a file under a released package's src/, so the repo's own gate owes a declaration. It is answered with an empty-frontmatter changeset, which that gate documents as a first-class pass rather than a workaround.
  • Left in draft for the PM seat; CI convergence is not awaited here.

Generated by Claude Code

…ot line address

The `### NON_GRID_ROW_CEILING` case named its instance `packages/react/README.md:224`.
The heading moved to :253 and nothing went red: the test asserts an inline string and
never reads the file, so the address lived only in the test name. Drop the address
rather than update it — the heading text is already the identifying content and is
already in the assertion one line below.

The same file built three more names by interpolating a `where` field that carried
five more line addresses; those are dropped to file paths for the same reason. A
comment records the convention so the class does not return here.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QnpvbdoRisQdRAczkLwnf5
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 50 chunks) 3186.0 KB 3191.4 KB
Main entry chunk (gzip) 143.5 KB 350 KB
Entry file index-DuMkzIKe.js
Status PASS

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 15.67KB 5.75KB
app-shell (runtime-config.js) 20.68KB 7.36KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.06KB 3.86KB
auth (ActiveOrganizationStorage.js) 25.05KB 9.16KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.18KB 10.59KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.39KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.65KB 2.22KB
auth (SocialSignInButtons.js) 9.61KB 3.89KB
auth (UserMenu.js) 3.41KB 1.23KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.21KB 10.80KB
auth (createAuthenticatedFetch.js) 8.46KB 3.43KB
auth (index.js) 3.19KB 1.44KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 5.13KB 2.35KB
collaboration (CommentThread.js) 26.08KB 7.56KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.49KB 2.64KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.05KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 497.06KB 113.79KB
core (index.js) 6.96KB 2.79KB
create-plugin (index.js) 10.08KB 3.26KB
data-objectstack (index.js) 182.08KB 50.62KB
fields (index.js) 242.44KB 61.25KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 1.22KB 0.64KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 4.28KB 1.75KB
i18n (index.js) 3.65KB 1.47KB
i18n (pickLocalized.js) 7.62KB 3.26KB
i18n (provider.js) 26.89KB 9.04KB
i18n (useDisplayLocale.js) 2.85KB 1.45KB
i18n (useObjectLabel.js) 34.34KB 9.17KB
i18n (useSafeTranslation.js) 5.60KB 2.33KB
layout (index.js) 38.84KB 10.94KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 4.39KB 1.66KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 11.71KB 4.29KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.24KB 2.16KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 5.12KB 1.74KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 15.16KB 3.68KB
plugin-calendar (index.js) 47.29KB 13.18KB
plugin-charts (index.js) 70.43KB 19.71KB
plugin-chatbot (index.js) 193.53KB 46.05KB
plugin-dashboard (index.js) 131.41KB 34.43KB
plugin-designer (index.js) 211.51KB 43.01KB
plugin-detail (index.js) 247.59KB 63.48KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 131.01KB 32.32KB
plugin-gantt (index.js) 167.16KB 40.99KB
plugin-grid (index.js) 208.56KB 56.63KB
plugin-kanban (index.js) 52.30KB 14.49KB
plugin-list (index.js) 113.24KB 27.66KB
plugin-map (index.js) 20.35KB 6.77KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 43.42KB 11.92KB
plugin-timeline (index.js) 29.95KB 8.67KB
plugin-tree (index.js) 9.19KB 3.19KB
plugin-view (index.js) 84.33KB 20.75KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.66KB 3.50KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 81.07KB 26.86KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.63KB 2.18KB
react (schema-input.js) 2.32KB 1.24KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (codegen.js) 5.41KB 2.34KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 4.93KB 2.24KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 20.57KB 5.88KB
sdui-parser (provenance.js) 3.66KB 1.82KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 10.35KB 3.60KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 1.00KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 2.74KB 1.41KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 4.74KB 2.25KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 4.73KB 2.28KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 5.05KB 1.93KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-steve
os-steve marked this pull request as ready for review September 6, 2026 13:04
@os-steve
os-steve added this pull request to the merge queue Sep 6, 2026
Merged via the queue into main with commit a8f4bd7 Sep 6, 2026
33 of 34 checks passed
@os-steve
os-steve deleted the claude/issue-7913-toc-anchor-cite-by-content branch September 6, 2026 13:19
baozhoutao pushed a commit that referenced this pull request Sep 6, 2026
Brings in #8046, #8042, #8039. Neither of this branch's two paths is touched by
that range; plugin-view source moved, so the forced build and every gate are
re-run on the merged head.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FhBNJcLRZLe8M87VcUgpKr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants