fix(api): drop unused @ts-expect-error that breaks CI typecheck

[shuvamk]

Problem

CI's Typecheck job is failing on main (and therefore on every open PR branched from it):

src/lib/startup/self-edge.test.ts(42,3): error TS2578: Unused '@ts-expect-error' directive.

This started with 3381e54 (#114), which introduced apps/api/src/lib/startup/self-edge.test.ts. The three most recent CI runs on main are red — the Typecheck apps/api step exits 2, which also short-circuits the Typecheck apps/dashboard step so it never runs.

Cause

process.getuid is typed (() => number) | undefined in @types/node 22 (^22.13.0, resolving to 22.19.15), so:

process.getuid = () => 0;

is already valid TypeScript — nothing to suppress. tsc treats a @ts-expect-error that suppresses no error as an error in its own right (TS2578).

The teardown a few lines below already assigns to the same property with no directive, which confirms the assignment type-checks on its own:

afterEach(() => {
  ...
  process.getuid = origGetuid;
});

Fix

Remove the directive, keep the explanatory comment. One line.

Verification

Run against this branch:

• bun run --cwd apps/api lint → clean, exit 0 (was: TS2578, exit 2)
• apps/dashboard tsc --noEmit (the CI filter step) → passes
• bun run test → 5/5 turbo tasks successful, matching CI's counts exactly:
  • @repo/api 695 passed / 3 skipped
  • @repo/adapters 222 passed
  • @repo/core 89 passed
  • @repo/db 25 passed
  • @repo/dashboard 17 passed
• The three ensureSelfEdgeInfra tests in the touched file pass unchanged (vitest run src/lib/startup/self-edge.test.ts → 3 passed).

No behavior change — this only unblocks the typecheck gate.

[shuvamk]

Quick heads-up now that #118, #120 and #121 have landed — main's Typecheck job is still red, and this PR is the fix for it.

The merge commit for #121 (run 29959055592) failed with the same single error:

src/lib/startup/self-edge.test.ts(42,3): error TS2578: Unused '@ts-expect-error' directive.

Every push to main will keep failing that job until this one-line change goes in, and because the step exits 2 it also short-circuits Typecheck apps/dashboard, so that step never runs at all.

No rush from my side — just flagging it since the red X on the merges above is this and not those changes.