Skip to content

fix: surface compose parser errors during prepare - #339

Merged
Hydralerne merged 1 commit into
oblien:mainfrom
onyedikachi-david:fix/compose-preview-parser-errors
Jul 30, 2026
Merged

fix: surface compose parser errors during prepare#339
Hydralerne merged 1 commit into
oblien:mainfrom
onyedikachi-david:fix/compose-preview-parser-errors

Conversation

@onyedikachi-david

Copy link
Copy Markdown
Contributor

Summary

Surface Docker Compose parser errors instead of returning zero services.

Motivation

OpenShip Desktop could stay loading when Compose parsing failed, such as for a missing ${VAR:?message} value. The API swallowed the error, so the UI received no actionable failure.

Related issue

None.

Changes

apps/api

  • Return a contextual Compose parser error.
  • Add tests for missing required variables and invalid YAML.

Verification

bun run --cwd apps/api test -- test/modules/deployments/prepare.service.test.ts
# 3 tests passed

bun run --cwd apps/api lint
# passed

git diff --check
# passed

Checklist

  • One change per PR
  • The diff is scoped
  • A regression test covers the bug
  • Full monorepo tests and formatting pass
  • I understand the diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants