fix(mail): prevent concurrent setup runs - #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
409immediately when another replica owns the server lock503instead of running unlocked when reservation persistence failsWhy
The previous
activecheck and assignment were separated by an awaited database lookup, so two requests could both pass the check. Themail_serversfallback was also not an atomic lock becauseupsert()updates on conflict.The former one-hour row heuristic also blocked intentional DNS/PTR resumes and could expire while a valid long-running install was still active. A session-level advisory lock follows the actual SSE lifecycle instead of relying on elapsed time.
Tests
bun run --cwd apps/api lintbun run --cwd packages/db lintbun formatwas run per CONTRIBUTING.md. Its repository-wide Windows line-ending churn and unrelated formatting changes were excluded; the pre-existingmail.controller.tsfile is not fully Prettier-clean onmain.Fixes #79