chore: restore green CI on the current toolchain - #33
Open
bobzhang wants to merge 2 commits into
Open
Conversation
`moon check --deny-warn` fails on `main` with the current toolchain
(moonc v0.10.11+6ff76a5f9):
internal/header/header.mbt:41:13
let buf = StringBuilder::new()
Warning (deprecated): Use `StringBuilder()` instead
Six occurrences across three files.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AmoyPMELemz5hdNNdXyAkm
`moon fmt` + `git diff --exit-code` is a CI gate, and it fails on `main` with the current toolchain (moon 0.1.20260827 / moonc v0.10.11+6ff76a5f9). Formatting only; `moon fmt` is at a fixed point afterwards. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AmoyPMELemz5hdNNdXyAkm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maincurrently fails two of its own CI gates on the released toolchain (moon 0.1.20260827/moonc v0.10.11+6ff76a5f9). The last green run was 2026-08-22, so the toolchain appears to have moved since. Any PR opened today goes red before its tests ever run — that is how I noticed, in #32.Two commits, each a separate concern:
1.
fix: replace deprecated StringBuilder::new() with StringBuilder()moon check --deny-warn(CI step 6) fails:Six occurrences across
index.mbt,internal/header/header.mbt,utils.mbt.This is the one that actually blocks everything:
moon checkfailing means steps 7–10 are skipped, somoon info,moon fmtandmoon testnever run at all on any PR.2.
chore: apply moon fmtmoon fmt+git diff --exit-code(CI step 8) fails. 15 files, formatting only.moon fmtis at a fixed point afterwards — re-running produces nothing further.Verification
All four CI steps, run locally on this branch with the toolchain CI installs:
moon check --deny-warnmoon info --target native+git diff --exit-codemoon fmt+git diff --exit-codemoon test --target js,nativeRelationship to #32
#32 (replacing the removed
moonbitlang/core/strconv) is currently red for exactly these reasons, not for anything it changes. I kept the two apart so a 7-line dependency fix would not arrive buried in a 17-file reformat.With this branch as the base, #32's change passes all four gates — I verified the combination locally (
--deny-warn0,fmt --check0, 105/100 tests). So merging this first should turn #32 green with no changes needed there.Entirely happy for you to take only the first commit, or to close this if the formatting is intentional — the
StringBuilderone is the blocker; themoon fmtone is just the next gate behind it.🤖 Generated with Claude Code
https://claude.ai/code/session_01AmoyPMELemz5hdNNdXyAkm