Skip to content

Obsolete 'cestode' (UBERON:0018387).#2258

Merged
dosumis merged 1 commit intomasterfrom
deprecate-cestode
Jan 27, 2022
Merged

Obsolete 'cestode' (UBERON:0018387).#2258
dosumis merged 1 commit intomasterfrom
deprecate-cestode

Conversation

@gouttegd
Copy link
Collaborator

The term cestode (UBERON:0018387) represents a taxon and as such does not belong in Uberon. Obsolete it and propose NCBITaxon:6199 as replacement term.

close #1835

The term 'cestode' (UBERON:0018387) represents a taxon and as such does
not belong in Uberon. Obsolete it and propose NCBITaxon:6199 as
replacement term.

close #1835
@gouttegd gouttegd self-assigned this Jan 27, 2022
@gouttegd
Copy link
Collaborator Author

@paolaroncaglia If you merely approve a PR, is that already a potential conflict-of-interest?

Copy link
Contributor

@paolaroncaglia paolaroncaglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gouttegd Thank you for taking care of this. It all looks good to me, but 1) I haven't obsoleted terms in Uberon previously (I'd think it works the same as for other OBO ontologies though) and 2) based on a present discussion elsewhere, I'm not 100% sure if the NCBITaxon class should be entered differently, see #2257 (comment) and #1904 (comment)

@paolaroncaglia
Copy link
Contributor

(The tests to check for correctness of taxon annotations might be inactive at the moment, so just in case...)

@gouttegd
Copy link
Collaborator Author

For 1) I am not aware of any Uberon-specific guidelines regarding obsoletion, and I’ve followed what was done in some recent examples of obsoletions in Uberon, so presumably this should be good.

For 2) I did enter the IRI for NCBITaxon:6199 as exemplified in #2257. :) This is why NCBITaxon:6199 appears in the OBO file as a “naked” identifier and not as a quoted string.

@paolaroncaglia
Copy link
Contributor

@gouttegd great, thanks!

@dosumis dosumis merged commit 8f2c045 into master Jan 27, 2022
@dosumis dosumis deleted the deprecate-cestode branch January 27, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UBERON:0018387 cestode

3 participants