Skip to content

Add contributor value check#2273

Merged
anitacaron merged 13 commits intomasterfrom
dc-contributor-check
Feb 18, 2022
Merged

Add contributor value check#2273
anitacaron merged 13 commits intomasterfrom
dc-contributor-check

Conversation

@anitacaron
Copy link
Collaborator

@anitacaron anitacaron commented Jan 31, 2022

I am waiting for PR #2213 to be merged to fix the curators' group contribution.

@anitacaron anitacaron self-assigned this Feb 1, 2022
@anitacaron anitacaron marked this pull request as draft February 1, 2022 17:50
@anitacaron anitacaron requested a review from matentzn February 1, 2022 18:21
Just cosmetic, using the recommendation on bioregistry:

http://bioregistry.io/registry/dcterms
@matentzn
Copy link
Contributor

matentzn commented Feb 2, 2022

  • Can we try to turn orcids wikidatas and rors into IRIs in Uberon and see how that looks like in OWL?

@dosumis dosumis added the tech label Feb 11, 2022
@matentzn
Copy link
Contributor

This is such a beautiful pull request.. It pains me to see it unmerged. :) Very well done all of it, I think its all correct, but unfortunately we need to do the detective work now..

@anitacaron anitacaron marked this pull request as ready for review February 18, 2022 11:35
@anitacaron anitacaron requested a review from matentzn February 18, 2022 11:35
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anita can you share a single screen shot in protege how one of these orcids show up in an annotation pane? Great work!

@anitacaron
Copy link
Collaborator Author

Screenshot 2022-02-18 at 16 22 34

@anitacaron anitacaron merged commit 0ee560e into master Feb 18, 2022
@matentzn matentzn deleted the dc-contributor-check branch February 18, 2022 19:05
@matentzn
Copy link
Contributor

AMAZING! Thank you!! Great job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants