Change external pudendal vein tributary_of to connected_to#2304
Merged
shawntanzk merged 4 commits intomasterfrom Feb 16, 2022
Merged
Change external pudendal vein tributary_of to connected_to#2304shawntanzk merged 4 commits intomasterfrom
shawntanzk merged 4 commits intomasterfrom
Conversation
Collaborator
|
This is related to #2293 |
Contributor
|
Suggested fix external pudendal vein SubClassOf tributary of some femoral vein [core.owl] |
Contributor
|
If that's too much hassle to get release out now, we could keep current fix and resolve later. It's not such a big deal I think. |
Collaborator
Author
Adding this is in addition to removing |
Collaborator
Author
|
oh tested it, and i guess you mean instead of removing the relationship |
shawntanzk
changed the title
shawntanzk
changed the title
Collaborator
Author
|
Merging this given its @dosumis preference and we were waiting for his input anyway |
shawntanzk
deleted the
remove-femoral-vein-SubClassOf-part_of-some-hindlimb
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to be the offending axiom that is causing the unsats
unsats come at tmp/uberon-edit.owl
When this axiom was removed in there, unsats went away.
@dosumis you mentioned that this is due to over-use of partonomy in representing vasculature -> does that mean removing the axiom is perfectly fine?
Thanks
Fixes #2293