Skip to content

Fixes #2407 NTR sublumbar lymph node#2500

Merged
4 commits merged into
masterfrom
2407-NTR-sublumbar-lymph-node
May 31, 2022
Merged

Fixes #2407 NTR sublumbar lymph node#2500
4 commits merged into
masterfrom
2407-NTR-sublumbar-lymph-node

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented May 26, 2022

Fixes #2407 NTR sublumbar lymph node

@ghost ghost added the new term request label May 26, 2022
@ghost ghost self-assigned this May 26, 2022
@ghost ghost requested review from paolaroncaglia and shawntanzk May 26, 2022 12:23
@ghost
Copy link
Copy Markdown
Author

ghost commented May 26, 2022

@shawntanzk, this term is from the robot template you created. I wanted to make some movement on this group of new term requests, so I am starting to manually add them until I get trained on robot. I also find it easier to curate these manually in Protégé instead of in a spreadsheet.
As more are added manually, I'll remove them from the template.

@shawntanzk
Copy link
Copy Markdown
Collaborator

sure totally up to you, but if you want me to just get them all in in a branch using robot template, happy to do so

@ghost
Copy link
Copy Markdown
Author

ghost commented May 26, 2022

sure totally up to you, but if you want me to just get them all in in a branch using robot template, happy to do so

Several terms on the present list require some clarifications, so will hold off on a batch addition for now. Once there is a list with straightforward entries, I'd like to learn how to add them via robot commands.

@ghost
Copy link
Copy Markdown
Author

ghost commented May 27, 2022

Thanks, @shawntanzk. Does this term seem ready to merge?

@shawntanzk
Copy link
Copy Markdown
Collaborator

your QC failed, so no, I'm running a release atm so I can't help check whats going wrong, but I'm guessing its:

property_value: http://purl.org/dc/elements/1.1/contributor http://orcid.org/0000-0002-1773-2692
property_value: http://purl.org/dc/elements/1.1/date 2022-05-26T11:59:51Z xsd:dateTime

these should be dc terms instead of dc elements

@ghost
Copy link
Copy Markdown
Author

ghost commented May 27, 2022

these should be dc terms instead of dc elements

Yes, now I remember. Can / should we remove the dc elements property values from Protégé if they are not meant to be selected?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2022

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2022-05-30/uberon-simple.owl
  • Loaded from: file:/work/src/ontology/../../master/src/ontology/uberon-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2022-05-30/uberon-simple.owl
  • Loaded from: file:/work/src/ontology/uberon-simple.owl

Ontology imports

Ontology annotations

UBERON_8470001 http://purl.obolibrary.org/obo/UBERON_8470001

Added

internal iliac lymph node http://purl.obolibrary.org/obo/UBERON_0015881

Added

medial common iliac lymph node http://purl.obolibrary.org/obo/UBERON_0037532

Added

sacral lymph node http://purl.obolibrary.org/obo/UBERON_0002528

Removed

Added

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2022

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/work/src/ontology/uberon-edit.obo

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/work/src/ontology/../../master/src/ontology/uberon-edit.obo

Ontology imports

Ontology annotations

internal iliac lymph node http://purl.obolibrary.org/obo/UBERON_0015881

Removed

medial common iliac lymph node http://purl.obolibrary.org/obo/UBERON_0037532

Removed

sacral lymph node http://purl.obolibrary.org/obo/UBERON_0002528

Removed

sublumbar lymph node http://purl.obolibrary.org/obo/UBERON_8470001

Removed

@shawntanzk
Copy link
Copy Markdown
Collaborator

Can / should we remove the dc elements property values from Protégé if they are not meant to be selected?

don't think we can - this rule is specific to the ontologies we care about only, so making a change on protege isn't possible. However, I'm not sure how protege populates the annotations list and which it highlights, think it has something to do with what is declared in the file, though not sure how that works with obo file format. Anyway that's the reason the check is there so that it picks it up before going through :)

Comment thread src/ontology/uberon-edit.obo
@ghost ghost requested a review from paolaroncaglia May 30, 2022 17:02
@ghost ghost merged commit 996436a into master May 31, 2022
@anitacaron anitacaron deleted the 2407-NTR-sublumbar-lymph-node branch February 10, 2023 18:14
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NTR: sublumbar lymph node

2 participants