Skip to content

Add upper and lower layers of the cortex#2733

Merged
shawntanzk merged 1 commit into
masterfrom
add-upper-and-lower-cortex
Dec 14, 2022
Merged

Add upper and lower layers of the cortex#2733
shawntanzk merged 1 commit into
masterfrom
add-upper-and-lower-cortex

Conversation

@shawntanzk
Copy link
Copy Markdown
Collaborator

#gogoeditdiff
Not my favourite definitions and would like feedback
Fixes #2722

#gogoeditdiff
Not my favourite definitions and would like feedback
Fixes #2722
@shawntanzk shawntanzk self-assigned this Dec 8, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 8, 2022

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2022-12-08/uberon-simple.owl
  • Loaded from: file:/work/src/ontology/../../master/src/ontology/uberon-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2022-12-08/uberon-simple.owl
  • Loaded from: file:/work/src/ontology/uberon-simple.owl

Ontology imports

Ontology annotations

UBERON_8440044 http://purl.obolibrary.org/obo/UBERON_8440044

Added

UBERON_8440051 http://purl.obolibrary.org/obo/UBERON_8440051

Added

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 8, 2022

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/work/src/ontology/../../master/src/ontology/uberon-edit.obo

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/work/src/ontology/uberon-edit.obo

Ontology imports

Ontology annotations

UBERON_8440044 http://purl.obolibrary.org/obo/UBERON_8440044

Added

UBERON_8440051 http://purl.obolibrary.org/obo/UBERON_8440051

Added

Copy link
Copy Markdown
Collaborator

@patrick-lloyd-ray patrick-lloyd-ray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the definitions are fine -- the "surface"/"deep" modifiers may not be the most accurate but they are intuitive and express what is meant by the terms well.

@shawntanzk shawntanzk merged commit c73388d into master Dec 14, 2022
@shawntanzk shawntanzk deleted the add-upper-and-lower-cortex branch December 14, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upper and Lower Cortex

2 participants