Skip to content

Addresses #2714 NTR 'moderator band'#2741

Merged
6 commits merged into
masterfrom
2714-NTR-septomarginal_trabecula
Dec 15, 2022
Merged

Addresses #2714 NTR 'moderator band'#2741
6 commits merged into
masterfrom
2714-NTR-septomarginal_trabecula

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Dec 13, 2022

Addresses #2714 NTR 'moderator band' (syn: septomarginal trabecula)
#gogoeditdiff

@ghost ghost self-assigned this Dec 13, 2022
@ghost ghost added the new term request label Dec 13, 2022
@ghost ghost linked an issue Dec 13, 2022 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 13, 2022

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2022-12-14/uberon-simple.owl
  • Loaded from: file:/work/src/ontology/../../master/src/ontology/uberon-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2022-12-14/uberon-simple.owl
  • Loaded from: file:/work/src/ontology/uberon-simple.owl

Ontology imports

Ontology annotations

UBERON_8470002 http://purl.obolibrary.org/obo/UBERON_8470002

Added

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 13, 2022

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/work/src/ontology/../../master/src/ontology/uberon-edit.obo

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/work/src/ontology/uberon-edit.obo

Ontology imports

Ontology annotations

UBERON_8470002 http://purl.obolibrary.org/obo/UBERON_8470002

Added

@ghost ghost requested review from emquardokus and shawntanzk December 13, 2022 14:45
Copy link
Copy Markdown
Collaborator

@shawntanzk shawntanzk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline

Comment thread src/ontology/uberon-edit.obo Outdated
Comment thread src/ontology/uberon-edit.obo Outdated
bvarner-ebi added 4 commits December 13, 2022 16:12
Edited text def and replaced 'located in' axiom with 'part of' subclass
Copy link
Copy Markdown
Collaborator

@emquardokus emquardokus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve of moderator band naming change and definition. I've added a different citation you may want to use instead of the Juniper press article for comparative anatomy, although it is more narrow to only pigs. Otherwise, looks good. thank-you

@ghost ghost merged commit 3788318 into master Dec 15, 2022
@ghost ghost deleted the 2714-NTR-septomarginal_trabecula branch December 15, 2022 08:57
@ghost ghost changed the title Addresses #2714 NTR septomarginal trabecula Addresses #2714 NTR 'moderator band' Dec 15, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[NTR] Moderator band a.ka. Septomarginal trabecula (heart)

2 participants