Skip to content

Conversation

@cmungall
Copy link
Member

@cmungall cmungall commented Jul 4, 2025

@cmungall cmungall requested review from Copilot and dosumis July 11, 2025 01:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new GitHub Actions workflow to install and configure the Copilot environment (including ROBOT, obo-scripts, and Python tools) and adds a placeholder instructions file.

  • Defines .github/workflows/copilot-setup-steps.yml to cache, download, and set up required tools for Copilot operations.
  • Adds .github/copilot-instructions.md which currently references external CLAUDE documentation.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/copilot-setup-steps.yml New workflow for setting up ROBOT, obo-scripts, UV, and Python venv
.github/copilot-instructions.md Placeholder instructions file linking to external documentation
Comments suppressed due to low confidence (7)

.github/workflows/copilot-setup-steps.yml:2

  • The inputs block is incorrectly placed at the top level. If you intend to accept inputs via workflow_dispatch, move this under on.workflow_dispatch.inputs, or switch to on.workflow_call for reusable workflows.
inputs:

.github/workflows/copilot-setup-steps.yml:45

  • This hard-codes the ROBOT version in the cache key. Consider using the robot-version input (e.g., ${{ inputs.robot-version }}) to keep the cache key in sync and allow overrides.
        key: ${{ runner.os }}-robot-v1.9.7

.github/workflows/copilot-setup-steps.yml:52

  • The download URL hard-codes the ROBOT version. Replace 'v1.9.7' with the robot-version input variable to support version overrides.
          curl -L https://github.com/ontodev/robot/releases/download/v1.9.7/robot.jar -o ~/.jar-cache/robot.jar

.github/workflows/copilot-setup-steps.yml:59

  • This URL also uses a hard-coded ROBOT version. Use the robot-version input to construct the path dynamically and keep it consistent.
        curl -L https://raw.githubusercontent.com/ontodev/robot/v1.9.7/bin/robot -o ${{ github.workspace }}/tools/robot

.github/copilot-instructions.md:1

  • [nitpick] This file currently only contains a path. Consider formatting it as a markdown link (e.g., [See CLAUDE](../CLAUDE.md)) or adding context so its purpose is clear.
../CLAUDE.md

.github/workflows/copilot-setup-steps.yml:67

  • [nitpick] These ls commands appear to be debugging steps and may clutter the workflow logs. Consider removing them or wrapping them in a debug-only condition.
        ls -alt ${{ github.workspace }}

.github/workflows/copilot-setup-steps.yml:73

  • [nitpick] Cloning the default branch can lead to non-reproducible builds. Pin to a specific tag or commit hash for stability.
        git clone https://github.com/cmungall/obo-scripts.git ${{ github.workspace }}/tools/obo-scripts

cmungall added a commit to obophenotype/cell-ontology that referenced this pull request Jul 11, 2025
@cmungall
Copy link
Member Author

Consider using the robot-version input

I am not sure this works with copilot mode. TODO check

@cmungall cmungall merged commit 35a787c into master Jul 22, 2025
@dosumis dosumis deleted the copilot-instructions branch September 15, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants