-
Notifications
You must be signed in to change notification settings - Fork 37
adding copilot #3580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding copilot #3580
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new GitHub Actions workflow to install and configure the Copilot environment (including ROBOT, obo-scripts, and Python tools) and adds a placeholder instructions file.
- Defines
.github/workflows/copilot-setup-steps.ymlto cache, download, and set up required tools for Copilot operations. - Adds
.github/copilot-instructions.mdwhich currently references external CLAUDE documentation.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/copilot-setup-steps.yml | New workflow for setting up ROBOT, obo-scripts, UV, and Python venv |
| .github/copilot-instructions.md | Placeholder instructions file linking to external documentation |
Comments suppressed due to low confidence (7)
.github/workflows/copilot-setup-steps.yml:2
- The inputs block is incorrectly placed at the top level. If you intend to accept inputs via workflow_dispatch, move this under on.workflow_dispatch.inputs, or switch to on.workflow_call for reusable workflows.
inputs:
.github/workflows/copilot-setup-steps.yml:45
- This hard-codes the ROBOT version in the cache key. Consider using the robot-version input (e.g., ${{ inputs.robot-version }}) to keep the cache key in sync and allow overrides.
key: ${{ runner.os }}-robot-v1.9.7
.github/workflows/copilot-setup-steps.yml:52
- The download URL hard-codes the ROBOT version. Replace 'v1.9.7' with the robot-version input variable to support version overrides.
curl -L https://github.com/ontodev/robot/releases/download/v1.9.7/robot.jar -o ~/.jar-cache/robot.jar
.github/workflows/copilot-setup-steps.yml:59
- This URL also uses a hard-coded ROBOT version. Use the robot-version input to construct the path dynamically and keep it consistent.
curl -L https://raw.githubusercontent.com/ontodev/robot/v1.9.7/bin/robot -o ${{ github.workspace }}/tools/robot
.github/copilot-instructions.md:1
- [nitpick] This file currently only contains a path. Consider formatting it as a markdown link (e.g.,
[See CLAUDE](../CLAUDE.md)) or adding context so its purpose is clear.
../CLAUDE.md
.github/workflows/copilot-setup-steps.yml:67
- [nitpick] These
lscommands appear to be debugging steps and may clutter the workflow logs. Consider removing them or wrapping them in a debug-only condition.
ls -alt ${{ github.workspace }}
.github/workflows/copilot-setup-steps.yml:73
- [nitpick] Cloning the default branch can lead to non-reproducible builds. Pin to a specific tag or commit hash for stability.
git clone https://github.com/cmungall/obo-scripts.git ${{ github.workspace }}/tools/obo-scripts
I am not sure this works with copilot mode. TODO check |
See ai4curation/aidocs#3