test(antigravity): realign mapping assertions with the pruned reference#1992
Closed
cwest wants to merge 1 commit into
Closed
test(antigravity): realign mapping assertions with the pruned reference#1992cwest wants to merge 1 commit into
cwest wants to merge 1 commit into
Conversation
cwest
marked this pull request as ready for review
July 15, 2026 16:52
cwest
marked this pull request as draft
July 15, 2026 17:02
e7ddc25 (obra#1847) intentionally trimmed the skill-loading explainer and the generic action→tool table from antigravity-tools.md, pruning to "the harness-specific notes that still carry weight." But tests/antigravity still asserted the removed tokens (view_file, IsSkillFile, SKILL.md, run_command, grep_search), so the antigravity suite has been red on dev ever since. Realign the test with the slimmed reference: assert only what the doc still documents — subagent dispatch (invoke_subagent, self/research types), the write_to_file/replace_file_content tools, and the task artifact mechanism — plus the SKILL.md Platform Adaptation link. Drop the assertions for the intentionally-removed tokens. Agents don't need the removed details: verified with a clean agy run where the plugin installs, skills load, and brainstorming auto-triggers without them. Related: obra#1987 independently proposed realigning these assertions (antigravity + pi); this is the narrower antigravity-only change.
cwest
force-pushed
the
topic/antigravity-tool-mapping
branch
from
July 15, 2026 17:08
c83e327 to
cc4e345
Compare
Author
|
Closing in favor of #1987 — it makes the same test realignment and also covers |
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Who is submitting this PR? (required)
claude-opus-4-8), via Google Vertex AIsuperpowersplugin was installed on the real Antigravity CLI (agy1.1.1) for live verificationagyCLIWhat problem are you trying to solve?
tests/antigravity/test-antigravity-tools.shfails ondev:e7ddc25(#1847) intentionally trimmed the skill-loading explainer and the generic action→tool table out ofantigravity-tools.md(pruning to "the harness-specific notes that still carry weight"), but did not updatetests/. The test still greps for tokens the prune removed —view_file,IsSkillFile,SKILL.md,run_command,grep_search— so the antigravity suite has been red ever since. The doc is correct as-is; the test is stale.What does this PR change?
Realigns
tests/antigravity/test-antigravity-tools.shwith the slimmed reference: it now asserts only what the doc still documents and agents rely on — subagent dispatch (invoke_subagent,self/research), thewrite_to_file/replace_file_contenttools, and the task-artifact mechanism — plus theSKILL.mdPlatform Adaptation link. Drops the assertions for the intentionally-removed tokens. One file (test only); the reference doc is untouched.Is this change appropriate for the core library?
Yes — it repairs an existing core test so the antigravity suite is green again. No new skill, domain, or third-party integration; no product behavior change.
What alternatives did you consider?
antigravity-tools.md(turn the test green by re-addingview_file/IsSkillFile/etc.). Rejected: Prune per-harness tool-mapping boilerplate #1847 removed that content deliberately, and a cleanagyrun confirms agents don't need it (skills load andbrainstormingauto-triggers without it). Re-adding it would reintroduce exactly what the prune set out to remove.Does this PR contain multiple unrelated changes?
No. Single file, single concern: make the stale antigravity test match the intentionally-pruned reference.
Existing PRs
#1987 (open) proposes the same realignment across two files (
tests/antigravity+tests/pi). This PR is the narrower, antigravity-only version — happy to defer to #1987 if you'd rather take the combined change; flagging it so you can choose.#1902 (closed) proposed the opposite fix (restoring the doc). Per the reasoning above, the doc-restore direction re-adds content #1847 intentionally removed, so this PR fixes the test instead.
Environment tested
agy)agyRepo suite (no model):
bash tests/antigravity/run-tests.sh→ PASS;bash tests/hooks/test-session-start.sh→ PASS;git diff --check→ clean.New harness support (required if this PR adds a new harness)
N/A — no new harness. As corroboration that the removed details aren't needed at runtime: on a clean, isolated
agy1.1.1 profile (agy plugin install <repo>) the plugin loaded 14 skills + the SessionStart hook, and a live session auto-triggeredbrainstormingbefore any code was written — without the pruned mapping lines present.Evaluation
devwith the error above.bash tests/antigravity/run-tests.shpasses; the test still catches real regressions (removinginvoke_subagent, theself/researchtypes, or the task-artifact mechanism from the doc still fails it).agyrun confirmed skills load/trigger without the removed tokens — i.e. the doc is correct as slimmed.Rigor
agyrun; confirmed the trimmed test still fails when a still-documented token is removed)Human review