Skip to content

feat(tui): dock and refine effect approvals - #100

Merged
killswitch-GUI merged 6 commits into
mainfrom
codex/tui-approval-dock
Aug 7, 2026
Merged

feat(tui): dock and refine effect approvals#100
killswitch-GUI merged 6 commits into
mainfrom
codex/tui-approval-dock

Conversation

@killswitch-GUI

@killswitch-GUI killswitch-GUI commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • move effect approvals into a compact dock above the preserved composer
  • keep the transcript visible and retain the operator's draft while approval is pending
  • present requester, action, resource, policy reason, and risk review as compact borderless rows
  • add inspectable Summary, Exact request, and Protections sections
  • use theme-resolved filled controls with an explicit unselected, fail-closed decision state
  • preserve inline terminal scrollback when transient approval chrome closes

Why

The previous full-screen approval inspector displaced the conversation, exposed a debug-oriented nested table, clipped important risk context, and made unresolved choices look visually similar to successful state. The refined dock keeps decision context visible without weakening explicit confirmation or fail-closed cancellation behavior.

User impact

Operators can review an approval in context, inspect exact request and protection details, and respond without losing their draft or transcript position. The compact layout remains usable at the minimum supported 40×12 terminal size.

Verification

  • cargo test -p colossus-tui --lib — 55 passed
  • cargo xtask check rust — passed
  • cargo build -p colossus-cli --bin colossus — passed

View with [code]smith
Need help on this PR? Tag @codesmith with what you need. Autofix is enabled.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 38c3b526aa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/colossus-tui/src/render.rs Outdated
killswitch-GUI and others added 2 commits August 7, 2026 00:26
@killswitch-GUI killswitch-GUI added the ci:full Run cost-bounded full pre-merge acceptance on the current PR head label Aug 7, 2026 — with ChatGPT Codex Connector
Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
@github-actions github-actions Bot removed the ci:full Run cost-bounded full pre-merge acceptance on the current PR head label Aug 7, 2026
@killswitch-GUI killswitch-GUI added the ci:full Run cost-bounded full pre-merge acceptance on the current PR head label Aug 7, 2026 — with ChatGPT Codex Connector
@killswitch-GUI
killswitch-GUI merged commit ae510fd into main Aug 7, 2026
28 of 29 checks passed
@killswitch-GUI
killswitch-GUI deleted the codex/tui-approval-dock branch August 7, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:full Run cost-bounded full pre-merge acceptance on the current PR head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant