perf(startup): reduce storage commit amplification - #108
Merged
Conversation
killswitch-GUI
marked this pull request as ready for review
August 8, 2026 03:28
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 06178f21c5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Open every required table with its typed definition inside the read transaction so an incompatible key/value definition is rejected at open time instead of surfacing during a later projection operation. Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Root cause
Plaintext/keyless startup still paid for durability work unrelated to journal encryption. Runtime composition eagerly created the disposable Tantivy index, redb reopened its established schema through an unconditional write transaction, and each non-applicable projection handler committed its checkpoint independently. Slow workspace-backed fsyncs amplified those commits.
Impact
On an isolated same-filesystem clone of the reported 895-event plaintext journal, time to first TUI render improved from 1.476 s to 0.618 s (58%). Journal append durability and hash-chain verification are unchanged.
Validation
cargo test -p colossus-memory -p colossus-projection -p colossus-journal-redb -p colossus-runtime --lib./scripts/check_crate_roots.shcargo xtask check rustNeed help on this PR? Tag
@codesmithwith what you need. Autofix is enabled.