feat(count): add tracker support to apache_combined generator#122
Open
Dylan-M wants to merge 1 commit into04-01-docs_count_add_finite_generation_documentationfrom
Conversation
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Dylan-M
changed the base branch from
04-01-docs_count_add_finite_generation_documentation
to
graphite-base/122
Dylan-M
force-pushed
the
graphite-base/122
branch
from
3c3b3e9 to
ed6455b
Compare
Dylan-M
force-pushed
the
04-01-feat_count_add_tracker_support_to_apache_combined_generator
branch
from
820ef3a to
41b8ec7
Compare
Dylan-M
changed the base branch from
graphite-base/122
to
04-01-docs_count_add_finite_generation_documentation
Dylan-M
changed the base branch from
04-01-docs_count_add_finite_generation_documentation
to
graphite-base/122
Dylan-M
force-pushed
the
04-01-feat_count_add_tracker_support_to_apache_combined_generator
branch
from
41b8ec7 to
6061846
Compare
Dylan-M
force-pushed
the
graphite-base/122
branch
from
ed6455b to
6c901df
Compare
Dylan-M
changed the base branch from
graphite-base/122
to
04-01-docs_count_add_finite_generation_documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Change
Add finite generation count support to the apache_combined generator. Adds
trackerfield,SetCountTracker()method, andAcquire()check in the worker loop before generation. When count is exhausted, workers pause and wait for resume (idle mode) or stop (exit mode).This PR is part of a stack for PIPE-926. The full implementation plan is attached as a document on that ticket.
Checklist