linux: Check for no desktop portal being present#199
Merged
RytoEX merged 1 commit intoobsproject:masterfrom Feb 6, 2026
Merged
linux: Check for no desktop portal being present#199RytoEX merged 1 commit intoobsproject:masterfrom
RytoEX merged 1 commit intoobsproject:masterfrom
Conversation
Member
|
Seems correct. @Penwy ? |
Penwy
suggested changes
Feb 3, 2026
Contributor
Penwy
left a comment
There was a problem hiding this comment.
Small nit to improve efficience by not doing a full file search when we don't need to, otherwise LGTM.
d4bf2ac to
4010509
Compare
RytoEX
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds an additional check to the existing
checkWayland()to make sure we have an XDG Portal at all.Motivation and Context
Came across a log in linux-support today, that looked like this:
Looks perfectly normal, right? Except, this user didn't have any XDG Portal set up at all, indicated by no
[pipewire]prefixed line in the log. The existing[pipewire] No captureline is only logged when the Portal responds but is not giving us any capture methods.I guess it could be argued this log line should also be output when there is no XDG portal at all, but I don't know if that's feasible and this works.
How Has This Been Tested?
With the aforementioned log.
Also tested three other logs to make sure it didn't break existing checks.
Types of changes
Checklist: