Skip to content

linux: Check for no desktop portal being present#199

Merged
RytoEX merged 1 commit intoobsproject:masterfrom
mihawk90:linux-pipewire-no-portal
Feb 6, 2026
Merged

linux: Check for no desktop portal being present#199
RytoEX merged 1 commit intoobsproject:masterfrom
mihawk90:linux-pipewire-no-portal

Conversation

@mihawk90
Copy link
Contributor

@mihawk90 mihawk90 commented Feb 2, 2026

Description

This adds an additional check to the existing checkWayland() to make sure we have an XDG Portal at all.

Motivation and Context

Came across a log in linux-support today, that looked like this:

image

Looks perfectly normal, right? Except, this user didn't have any XDG Portal set up at all, indicated by no [pipewire] prefixed line in the log. The existing [pipewire] No capture line is only logged when the Portal responds but is not giving us any capture methods.

I guess it could be argued this log line should also be output when there is no XDG portal at all, but I don't know if that's feasible and this works.

How Has This Been Tested?

With the aforementioned log.

Also tested three other logs to make sure it didn't break existing checks.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@RytoEX
Copy link
Member

RytoEX commented Feb 3, 2026

Seems correct. @Penwy ?

Copy link
Contributor

@Penwy Penwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit to improve efficience by not doing a full file search when we don't need to, otherwise LGTM.

@mihawk90 mihawk90 force-pushed the linux-pipewire-no-portal branch from d4bf2ac to 4010509 Compare February 3, 2026 21:27
@RytoEX RytoEX merged commit 0a43fc5 into obsproject:master Feb 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants