chore: fix autogenerated header for ci#14455
Merged
Merged
Conversation
Signed-off-by: Ali Caglayan <alizter@gmail.com>
shonfeder
approved these changes
May 8, 2026
Member
|
Ah yes, they were moved in #14250. |
Sudha247
approved these changes
May 8, 2026
Leonidas-from-XIV
approved these changes
May 8, 2026
Leonidas-from-XIV
left a comment
Leonidas-from-XIV
left a comment
Member
There was a problem hiding this comment.
I was a bit worried that moving the dune file into .github would make dune ignore the rules but turns out it works fine; confirming that dune runtest will register the a promotion.
Collaborator
Author
Normally yes, but we have this in |
Member
|
Ah that's good to know! Avoiding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The path we pass to the script is always correct since dune may relativise it whether it lives. The old hard coded path was incorrect since we moved the .in script.