fix(melange): avoid line directive when passing -loc-filename#14715
Merged
anmonteiro merged 1 commit intoMay 25, 2026
Merged
Conversation
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
anmonteiro
force-pushed
the
anmonteiro/melange-fix-double-source-mapping
branch
from
1092226 to
289d41d
Compare
shonfeder
pushed a commit
that referenced
this pull request
Jun 11, 2026
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
shonfeder
added a commit
that referenced
this pull request
Jun 11, 2026
Backport #14715 onto 3.24.0-rc. Fixes the melange build failure on OCaml 4.14 where dune emits an `I/O error: jscomp/runtime/.melange_src/X.mli: No such file or directory` against every `melange-re/melange.*-414` reverse dep (see ocaml/opam-repository#29996 — the 3.24.0~alpha2 release PR). The fix is to skip the line directive in `setup_melange_sources_copy_rules` when a module uses non-staged PPX, since the PPX pipeline now passes `-loc-filename` separately and adding the directive would double-shift diagnostics. The fix has a small precursor chain on `main`; bringing the headline `#14715` alone doesn't apply cleanly because subsequent PRs introduced the test files and machinery the fix's diff targets. Included PRs (chronological): - #14697 — test: show single context melange loses ppx snippet previews - #14698 — test: show single context reason+melange loses ppx snippet previews - #14708 — test: accept ppx loc-filename in fixtures - #14706 — **fix**: preserve original ppx source locations (introduces `-loc-filename`) - #14714 — test: reproduce reason source location regression - #14715 — **fix**: avoid line directive when passing `-loc-filename`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.