Skip to content

fix(melange): prefer melobjinfo for imported virtual-library dependencies - #16272

Merged
anmonteiro merged 5 commits into
ocaml:mainfrom
anmonteiro:anmonteiro/melobjinfo-imported-vlib-deps
Aug 31, 2026
Merged

fix(melange): prefer melobjinfo for imported virtual-library dependencies#16272
anmonteiro merged 5 commits into
ocaml:mainfrom
anmonteiro:anmonteiro/melobjinfo-imported-vlib-deps

Conversation

@anmonteiro

@anmonteiro anmonteiro commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Use melobjinfo to read precise implementation dependencies from installed Melange virtual-library CMJs, while retaining the CMT and conservative fallbacks.

Follow-up to #16211, #16212, and #16213. Test isolation is #16276. Uses melobjinfo from melange-re/melange#1858; the Nix development-shell update is #16271.

Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
@anmonteiro
anmonteiro force-pushed the anmonteiro/melobjinfo-imported-vlib-deps branch from d3d0994 to 69887b0 Compare August 31, 2026 05:29
anmonteiro added a commit that referenced this pull request Aug 31, 2026
Keep installed virtual-library fallback tests independent of whether
melobjinfo is available in the test environment.

Extracted from #16272.

Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
@anmonteiro
anmonteiro merged commit 2682f25 into ocaml:main Aug 31, 2026
36 of 37 checks passed
@Alizter Alizter added this to the 3.25.0 milestone Aug 31, 2026
anmonteiro added a commit that referenced this pull request Aug 31, 2026
Deduplicate sandbox selection between ocamlobjinfo and melobjinfo for
imported virtual libraries.

Follow-up to #16272.

Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

melange Melange rules and generator no changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants