[Haiku] Unix socket test+single-thread setlocale+signals - #14773
Conversation
Sylvain78
changed the title
kit-ty-kate
left a comment
kit-ty-kate
left a comment
There was a problem hiding this comment.
Could you do a proper rebase on top of trunk?
git pull --rebase origin trunk
edc47c5 to
17dc494
Compare
kit-ty-kate
left a comment
kit-ty-kate
left a comment
There was a problem hiding this comment.
I've only tested the previous version of this work (#14138) on a bare-metal Haiku R1/beta5 and i'm unable to go to my local hackerspace to test it again for another couple of months but it worked just fine at the time and the code is similar enough and seems satisfactory for my non-dev-team eyes.
|
This PR is a duplicate of #14773 (same branch) |
This is this PR? |
nojb
left a comment
nojb
left a comment
There was a problem hiding this comment.
LGTM, but please see small points below. (I'm holding off on approving formally until these are addressed.)
626452f to
1ab5fc5
Compare
OlivierNicole
left a comment
OlivierNicole
left a comment
There was a problem hiding this comment.
Approving on behalf @nojb whose points I believe have been addressed.
I took the liberty of editing the changelog to 1. add a missing newline and 2. remove David from the reviewers (the PR is assigned to him, but that’s for shepherding, not reviewing).
* Haiku native backend * Update Changes
6 participants
Activate Haiku backend
-Adapt to not test unnamed socket on haiku cause those ones receive a random name with format "\000xxxxx", so the comparison of old and new filename can't succeed on Haiku.
-setlocale is not thread safe on Haiku
-Splitting of signals unit test because sigio doesn't exist on Haiku