Skip to content

Re-allow .install files containing '..'#7008

Draft
kit-ty-kate wants to merge 2 commits into
ocaml:masterfrom
kit-ty-kate:revert-6897
Draft

Re-allow .install files containing '..'#7008
kit-ty-kate wants to merge 2 commits into
ocaml:masterfrom
kit-ty-kate:revert-6897

Conversation

@kit-ty-kate

@kit-ty-kate kit-ty-kate commented Jul 7, 2026

Copy link
Copy Markdown
Member

Partially reverts ae877c0 (from #6879)

This check is no longer necessary since d7f7d8e (#7005) and broke opam repositories providing cross-compiled packages as such format is used by dune (see ocaml/dune#14393)

See https://ocaml.zulipchat.com/#narrow/channel/527832-opam/topic/Cross.20compilation.20with.20opam.202.2E5.2E1/with/592359165

Backported to 2.5 in #7009

@rjbou rjbou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think it is better to avoid having links, especially non permanent ones on commit messages. If the message is deleted, or the zulip is no longer online, it is not possible to find out the origin that you wanted to highlight.

@kit-ty-kate kit-ty-kate marked this pull request as draft July 7, 2026 15:40
…tination filepath trying to escape their scope
Partially reverts ae877c0

This check is no longer necessary since d7f7d8e
and broke opam repositories providing cross-compiled packages

See https://ocaml.zulipchat.com/#narrow/channel/527832-opam/topic/Cross.20compilation.20with.20opam.202.2E5.2E1/with/592359165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants