Skip to content

fix: make lint usable for critical checks - #1008

Merged
lightzt99 merged 1 commit into
oceanbase:mainfrom
wayyoungboy:fix/issue-275-usable-lint
Jun 11, 2026
Merged

fix: make lint usable for critical checks#1008
lightzt99 merged 1 commit into
oceanbase:mainfrom
wayyoungboy:fix/issue-275-usable-lint

Conversation

@wayyoungboy

Copy link
Copy Markdown
Member

Summary

Closes #275.

This PR makes the default make lint target usable as a high-signal regression gate instead of reporting the full historical style backlog.

Changes:

  • adds an explicit Python >= 3.11 guard through the configurable PYTHON make variable
  • changes default make lint to check critical flake8 errors only: duplicate dict keys, undefined names, and syntax errors
  • moves the full flake8 report to make lint-full
  • keeps pylint available as optional make lint-pylint, so the default target no longer depends on a tool that is not installed by the current dev extras
  • fixes the currently reported critical lint failures

Validation

  • PYTHON=<python3.11> make lint
  • PYTHON=python3 make lint verifies the version guard reports a clear Python >= 3.11 requirement when the default interpreter is too old
  • git diff --check

@wayyoungboy
wayyoungboy marked this pull request as ready for review June 11, 2026 03:23
@lightzt99

Copy link
Copy Markdown
Collaborator

LGTM

@lightzt99
lightzt99 merged commit 11e3862 into oceanbase:main Jun 11, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement]: make lint reports thousands of flake8 errors

2 participants