Skip to content

Comments

Dependency & CI fixes#1030

Merged
kremalicious merged 5 commits intomainfrom
fix/ci
Jun 21, 2022
Merged

Dependency & CI fixes#1030
kremalicious merged 5 commits intomainfrom
fix/ci

Conversation

@kremalicious
Copy link
Contributor

@kremalicious kremalicious commented Jun 21, 2022

@netlify
Copy link

netlify bot commented Jun 21, 2022

Deploy Preview for docs-oceanprotocol ready!

Name Link
🔨 Latest commit 1d1aa40
🔍 Latest deploy log https://app.netlify.com/sites/docs-oceanprotocol/deploys/62b1b5d377999b2c4606fad9
😎 Deploy Preview https://deploy-preview-1030--docs-oceanprotocol.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 1d1aa40 and detected 0 issues on this pull request.

View more on Code Climate.

@kremalicious
Copy link
Contributor Author

kremalicious commented Jun 21, 2022

because we can't deploy anything right now. Do we want to stop updating any content of the docs until some magical migration in the future?

But yes, generally agree and this repo is a perfect example of what happens when maintenance of the underlying dependencies stops. We are now multiple major versions behind of most dependencies and they simply stop working in combination with other dependencies. Maintaining the docs in the future can only mean maintaining the tech too.

@kremalicious
Copy link
Contributor Author

kremalicious commented Jun 21, 2022

Had to explicitly set --legacy-peer-deps via NPM_FLAGS env vars in Netlify https://docs.netlify.com/configure-builds/manage-dependencies/#npm

All dependencies are multiple major versions behind, so everything in here is legacy and no general npm i will work

@kremalicious kremalicious marked this pull request as ready for review June 21, 2022 12:19
@kremalicious
Copy link
Contributor Author

kremalicious commented Jun 21, 2022

great, now npm start locally doesn't work anymore because of some other dependency conflict. I hate this unmaintained repo, probably easier to abandon it and just copy the content/ folder.

Deployment is more important than local development so merging anyway

@kremalicious kremalicious merged commit 63780c0 into main Jun 21, 2022
@kremalicious kremalicious deleted the fix/ci branch June 21, 2022 12:27
@alexcos20
Copy link
Member

thanks

@jamiehewitt15
Copy link
Contributor

probably easier to abandon it and just copy the content/ folder.

Yeah, good point. I'm happy to help with that if needed.

@jamiehewitt15
Copy link
Contributor

I created a new issue to discuss starting again with the docs #1031

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix builds Update lockfileVersion and use npm v >7

3 participants