Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/oceanprotocol/market/KieoABMVrNYeDFE6CyDEbmPvq45w |
* set isConsumable to true by default * kick out dtUtils, cleanup * cleanup * tweak AssetTeaser price check
|
Looks like the tests are failing, is this still a work in progress? |
|
Yeah, I just saw the tests. I'm working on it. |
|
Ok cool |
jamiehewitt15
left a comment
There was a problem hiding this comment.
It seems to work alright but you need to take a pull from origin main, as there are some changes to the publish page on main that aren't visible here. I'll check once more after you've done the pull
* filter ordered assets by service type * filter dids fetched * loader added * show loader fix Co-authored-by: claudia.holhos <claudia.holhos@hpm.ro>
|
Did you do a pull from origin main? There are some differences between the live version and you branch, for example the button on the main version is pink and the error messages and submission work differently: https://market.oceanprotocol.com/publish |
|
It seems to work ok but I'm not sure why there are so many additional changes in other files now? |
|
The changes are from |
|
Thanks Dimo, I've approved |
|
I found some strange behavior with toast when we re-add the same URL. It needs some more testing before merging. |
|
I've saw the issue with the toast messages appearing twice. Both the |
Fixes #490
Changes proposed in this PR: