Skip to content

Update the file info UI after URL re-add#524

Merged
DimitarSD merged 10 commits into
mainfrom
fix/490
Apr 21, 2021
Merged

Update the file info UI after URL re-add#524
DimitarSD merged 10 commits into
mainfrom
fix/490

Conversation

@DimitarSD

Copy link
Copy Markdown

Fixes #490

Changes proposed in this PR:

  • check for re-adding the same URL

@vercel

vercel Bot commented Apr 15, 2021

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/oceanprotocol/market/KieoABMVrNYeDFE6CyDEbmPvq45w
✅ Preview: https://market-git-fix-490-oceanprotocol.vercel.app

* set isConsumable to true by default

* kick out dtUtils, cleanup

* cleanup

* tweak AssetTeaser price check
@jamiehewitt15

Copy link
Copy Markdown
Contributor

Looks like the tests are failing, is this still a work in progress?

@DimitarSD

DimitarSD commented Apr 15, 2021

Copy link
Copy Markdown
Author

Yeah, I just saw the tests. I'm working on it.

@jamiehewitt15

Copy link
Copy Markdown
Contributor

Ok cool

@jamiehewitt15 jamiehewitt15 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work alright but you need to take a pull from origin main, as there are some changes to the publish page on main that aren't visible here. I'll check once more after you've done the pull

Comment thread .vscode/launch.json Outdated
claudiaHash and others added 2 commits April 15, 2021 14:54
* filter ordered assets by service type

* filter dids fetched

* loader added

* show loader fix

Co-authored-by: claudia.holhos <claudia.holhos@hpm.ro>
@DimitarSD DimitarSD marked this pull request as ready for review April 15, 2021 14:55
@DimitarSD DimitarSD requested a review from mihaisc as a code owner April 15, 2021 14:55
@jamiehewitt15

Copy link
Copy Markdown
Contributor

Did you do a pull from origin main? There are some differences between the live version and you branch, for example the button on the main version is pink and the error messages and submission work differently: https://market.oceanprotocol.com/publish

@jamiehewitt15

Copy link
Copy Markdown
Contributor

It seems to work ok but I'm not sure why there are so many additional changes in other files now?

@DimitarSD

Copy link
Copy Markdown
Author

The changes are from git rebase, i.e. fix/490 branch is up to date with the changes from the main branch.

@jamiehewitt15

Copy link
Copy Markdown
Contributor

Thanks Dimo, I've approved

@DimitarSD DimitarSD dismissed jamiehewitt15’s stale review April 16, 2021 08:14

we resolved the issue

@DimitarSD

Copy link
Copy Markdown
Author

I found some strange behavior with toast when we re-add the same URL. It needs some more testing before merging.

@jamiehewitt15

Copy link
Copy Markdown
Contributor

I've saw the issue with the toast messages appearing twice. Both the onClick() and onBlur() events were firing at the same time, so I removed the onclick() event (it's not needed if we have onBlur). I added e.preventDefault() as the onClick() event because otherwise the form will automatically attempt to submit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't re-enter same URL after removing it (Publish)

5 participants