Issue 582 market rbac integration#597
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/oceanprotocol/market/BqACwKygAByfhGX76d4z6b5FnBaT |
I am looking at the Vercel preview as that's what would be deployed to live. And there I get the screen posted above so I guess Vercel picks up |
Ok cool, I've removed the |
|
The latest vercel deployment doesn't require the wallet to be connected now |
This reverts commit 8bcb80b.
…ssue-582-market-rbac-integration
This reverts commit 9535e41.
|
Code Climate has analyzed commit 10b0136 and detected 0 issues on this pull request. View more on Code Climate. |
|
Did some quick tests with/without wallet, current functionality seems to be ok |
|
Thanks @mihaisc |
Closes: #582
Changes proposed in this PR:
Permissionscomponent to wrap elements that should be restricted due to access roles (browse, consume, publish)Steps for testing:
.envfile and add thefollowing URLs:Testing (without any permission restrictions):
In ocean market and other marketplace forks, there will be no need to have any permission based restrictions. This is made possible in this PR. If a
RBAC_URLis not defined then the permission response will always betrueand there will be no change in the user experience.To test:
RBAC_URLfrom.env.development:market/.env.development
Line 4 in 22c7302
npm run startand use it as per normal