Global search bar#690
Conversation
Signed-off-by: mihaisc <mihai.scarlat@smartcontrol.ro>
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/oceanprotocol/market/B3dsQKSuFNiQm3AXkHz2BnLpCMd8 |
|
B would be so nice but that's a lot to refactor I guess. So from behavior standpoint would go with A, but visually combine the two where the search field starts collapsed as search icon button only, and as viewport gets bigger search field can become more visible like Rarible does. On mobile the search field upon interaction can still take over the whole bar on top of other elements, but then searching still only happens when user hits enter. But then we need to make sure when user arrives on search page that searchbar is open by default |
|
I think you managed to design a more complicated way 😆. Ok i'll try to get in in a place where just UI changes are needed |
Signed-off-by: mihaisc <mihai@oceanprotocol.com>
Signed-off-by: mihaisc <mihai@oceanprotocol.com>
|
Needs more testing and the button interactions not that great. |
|
There are bugs when searching by owner or tags (when you click on owner or tag in asset details) that will be fixed once we merge main in the multinetwork branch. |
|
It terms of the search functionality, I'm noticing a couple issues which I thought we had solved in: #641
|
|
@jamiehewitt15 search fixes were not merged, so basically this is the old search with multiple bugs. Those will be merged in the multinetwork branch. |
|
Main is now merged.
This was not fixed, requires more work, it's a bit more complicated. |
jamiehewitt15
left a comment
There was a problem hiding this comment.
The functionality and styling look good to me. I just added a couple of minor comments on the code
|
Removed comments, should be ok now |
|
Looks good, I have approved |





Handles #665
Highly WIP. Functionality is sort of there.
What search pattern should we follow?
A. Easier way, like amazon


B. More design work (on mobile)



Bonus feature : search should trigger on 'enter'