Merged
Conversation
* Previous logic no longer works because newTokenAddress argument of
NFTCreated event is no longer indexed in latest contracts version
* Use FixedRateExchange.getExchanges() instead of event filters
* Not event logs
* Use ERC20Token.get_fixed_rates
mariacarmina
approved these changes
Apr 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #773.
Changes proposed in this PR:
This PR contains API breaking changes!
transferableandownerarguments todeploy_erc721_contract,create_nft_with_erc20,create_nft_erc20_with_pool,create_nft_erc20_with_fixed_rate,create_nft_erc20_with_dispenser,create_nft_with_metadataERC20Tokenmethods:get_pools,get_fixed_rates,get_dispensersERC721Factory.verify_nftto useget_idto determine if data NFT exists on chain instead of event filtering, which broke because thenewTokenAddressargument of theNFTCreatedevent is no longer indexed.ERC721Factory.search_exchange_by_datatokento useERC20Token.get_fixed_rates()instead of event filtering.fixed-rate-exchange-flow.mdandtest_fre_flow.pyto clarify value returned fromsearch_exchange_by_datatokenERC721NFTmethods related to "v3":set_data_v3,wrap_v3_dt,mint_v3_dt,add_v3_minter, andremove_v3_minter