Validation errors

[calina-c]

Closes #523

[calina-c]

I'm now thinking about another possible improvement: the error returned can be a key => value mapping:

• the key would be the field it arised on, nested with dots
• the value would be the error itself

@bogdanfazakas @alexcos20 would you like that? I'd like this intermediary version reviewed, tested and merged though, since it contains structural changes as well.

[alexcos20]

I support key => value errors descriptions, it makes it more readable by devs

[bogdanfazakas]

I support key => value errors descriptions, it makes it more readable by devs

I agree with Alex here, so besides the improvements from this PR would be nice to have key => value errors descriptions and use the new strings as values and some error codes as keys

[calina-c]

@bogdanfazakas is it ok with you if we merge this, since it contains structural changes? Then add in the key value logic?

[bogdanfazakas]

@bogdanfazakas is it ok with you if we merge this, since it contains structural changes? Then add in the key value logic?

The current state does not make our life easier on the client side, what about the previous suggestions from the PR ?, I'm fine with adding the key value logic later but, let's discuss the other stuff before merging.

[alexcos20]

lgtm, small issues that we can handle later
@bogdanfazakas - any last minute comments?

[bogdanfazakas]

lgtm, small issues that we can handle later @bogdanfazakas - any last minute comments?

lg, I think we can handle the changes in the market, does this really close #523 also ?

[calina-c]

lg, I think we can handle the changes in the market, does this really close #523 also ?

yep, all error messages are now key-value pairs with status messages :)