Update makemysql user check for carp#202
Merged
Merged
Conversation
On Nix there is no environment variable SUDO_USER
jaysa68
approved these changes
Apr 24, 2026
Member
|
Are you sure this works? On Debian at least, |
Contributor
Author
|
Yes. Tested and works on tsunami and koi. |
sophiebsw
added a commit
that referenced
this pull request
Jul 13, 2026
This reverts commit 7855927.
Member
|
this does not work properly and is not needed SUDO_USER is properly populated even on nixos, and the code in question will incorrectly return the uid of the mysql user |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUDO_USER does not exist as an accessible environment variable on Nix for the Python os module. Replaced with pwd username check.