feat(engine): protocol & transaction detection rules#24
Merged
Conversation
Add contract rules 4-10 to the detection engine, mirroring the toolkit's `core/detection.ts` thresholds and OCPP 1.6 vocabularies. - TIMEOUT_NO_HEARTBEAT — no Heartbeat within 2x the expected interval (Boot response, else 60s default), only when the trace runs past it. - METER_VALUE_GAP — a completed transaction with no MeterValues. - INVALID_STOP_REASON — StopTransaction reason outside the OCPP 1.6 set. - UNEXPECTED_START — StartTransaction with no preceding Boot or Authorize. - STATUS_TRANSITION_VIOLATION — illegal connector state-model transition. - DIAGNOSTICS_FAILURE / FIRMWARE_UPDATE_FAILURE — failure statuses. Each rule is tested on its trigger and its silent case. detectFailures now runs rules 1-10; the timing & anomaly batch and the conformance harness follow. Closes #20
sepehr-safari
added
type:feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Second slice of S2 — Detection + conformance: contract rules 4–10, the
protocol & transaction batch. Mirrors the toolkit's
core/detection.ts— thesame thresholds and OCPP 1.6 status / reason / firmware vocabularies.
Rules added
TIMEOUT_NO_HEARTBEATMETER_VALUE_GAPINVALID_STOP_REASONreasonoutside the OCPP 1.6 setUNEXPECTED_STARTSTATUS_TRANSITION_VIOLATIONDIAGNOSTICS_FAILUREUploadFailed/DiagnosisFailedFIRMWARE_UPDATE_FAILUREDownloadFailed/DownloadPaused/InstallFailed/InstallRebootingFaileddetectFailuresnow runs rules 1–10 in contract order.Testing
native test -Dplatform=null→ 43/43 pass (6 new tests: each rule on itstrigger and its silent case, driven through the real pipeline — including the
heartbeat threshold's "not enough trace to judge" boundary).
native check --strictandzig fmt --checkclean.Closes #20