Remove lwt_ppx dependency
#687
Conversation
This is done automatically using https://github.com/Julow/lwt_ppx_to_let_syntax/
The file might longer be uptodate according to 'os_db.ppx.ml'.
There was a problem hiding this comment.
I wasn't sure how to update this file so I let the tool run on it. Any guideline on how to setup the right environment to run the update command ?
src/os_db.ml
Outdated
| ( (fun password -> Bcrypt.string_of_hash (Bcrypt.hash password)) | ||
| , fun _ password1 password2 -> | ||
| ( (fun password -> Bcrypt.string_of_hash (Bcrypt.hash password)), | ||
| fun _ password1 password2 -> |
There was a problem hiding this comment.
Did you ocamlformat with our .ocamlformat?
There was a problem hiding this comment.
I understood that this file is generated from os_db.ppx.ml ? Generating it again will solve this.
This other file is not fully formatted either but I get large diffs messing up the readability of the queries so I tried to keep as few diffs as possible.
There was a problem hiding this comment.
Maybe. In that case we should probably remove it from the repository, isn't it?
There was a problem hiding this comment.
It's not generated automatically during build. Anyone knows how to update os_db.ml ?
There was a problem hiding this comment.
os_db.ml is uptodate ! This is ready to be merged.
This file is re-generated by running 'make rebuild-os-db' in an environment created with the template's 'make db-init db-create db-schema'.
2 participants
This PR removes the use of
lwt_ppxby rewritinglet%lwt,match%lwt, etc.. tolet*,Lwt.bindand other direct calls toLwtfunctions.Templates are also updated.
This was done using this tool: https://github.com/Julow/lwt_ppx_to_let_syntax/
The first commit runs OCamlformat to remove parasitic diffs in the other commits as the rewrite tool relies on OCamlformat too.
This is a first step toward moving from Lwt to effect-based concurrency. Here are related PRs on the other ocsigen projects: ocsigen/eliom#815 ocsigen/ocsigen-toolkit#236 ocsigen/ocsipersist#6