-
-
Notifications
You must be signed in to change notification settings - Fork 188
Refactored third-party modules import, changed build script and fixed few minor bugs #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored third-party modules import, changed build script and fixed few minor bugs #36
Conversation
|
If it's possible to not have the build system I'd like to avoid it and all the dependencies. I like it much better that I can write and reload the JS on the fly instead of having build/watch systems. What do you mean by The other two fixes are good -- thanks! |
You can do it with Webpack too:
It bundles all "browser" dependencies, auto injects script into HTML template, adds support for other "Web" features like a import no-TS/JS files (CSS for example). |
ahmadawais
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it but for some reason, the debugger doesn't work and the VSCode Extension Host doesn't launch.
I'm using TS for building the code running as extension, not the webview code.
Which I don't need. We are not building a whole app here. |
|
@octref Can you share where can I find API ref for webview in VSCode? |
|
@ahmadawais Sadly only https://github.com/Microsoft/vscode-extension-samples/tree/master/previewhtml-sample and https://code.visualstudio.com/docs/extensionAPI/vscode-api-commands#_working-with-the-html-preview. Currently @mjbvz is working on a new version of the API and he'll also add a dedicated doc page for developing webview extensions in our website. |
Good afternoon!
I changed the build system a little:
vivusanddom-to-image)tscbuild script with Webpack (I did it for betterwebviewsupport)Also I fixed few bugs (mistakes):
innerText->textContentclassList->className- because you assigned string to theclassList