You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Seven files asserted an "EU Electronics DPP adopted 18 March 2026" that no
instrument supports. Two of them — the electronics v1.0.0 and v1.1.0 schema
descriptions, which ship to crates.io — extended it into a fabricated
timeline naming AI servers, high-end PCBs and foldable phones with a
1 January 2027 second phase. Replaced with the real basis: Reg. (EU)
2023/1670 and 2023/1669, in force 2025-06-20, with dates left to the sector
manifest rather than restated.
cfb.rs described the battery carbon-footprint delegated act as adopted in
March 2025. It has not been adopted; it was due February 2025 and has
slipped. The module now says so and warns against mistaking (EU) 2025/606
(recycling efficiency) for it.
smartphone.rs gains a precision note only: the 2023/1669 method is in
Annex IV point 5 and the class boundaries in Annex II Table 4, and the
enacted index runs 1,00-5,00 against this heuristic's 0-10. The existing
Annex IV citations were correct and are unchanged.
No behaviour change. Full gate green.
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
The pull request successfully addresses the removal of speculative regulatory dates and clarifies the status of the Battery CFB methodology. Codacy analysis indicates the changes are up to standards.
However, there is an implementation gap regarding the smartphone repairability heuristic. While the core logic in smartphone.rs correctly labels the 0–10 scale as non-regulatory and distinct from the official EU index, the plugins/sector-electronics/src/lib.rs file still refers to an 'EU minimum' and uses the general 'EU Electronics DPP' mandate term. This inconsistency should be resolved to ensure the documentation aligns with the PR's goal of removing unsubstantiated regulatory claims.
About this PR
The removal of specific future dates (March/April 2026) is a necessary maintenance task to ensure the platform does not provide speculative or placeholder regulatory information to users.
1 comment outside of the diffplugins/sector-electronics/src/lib.rs
line 5 🟡 MEDIUM RISK
The documentation in this file is now inconsistent with the updates made in smartphone.rs. While the header was updated, the compliance rule (line 5) still describes a score < 4.0 as 'below EU minimum', and the plugin identity (line 30) still references the generic 'EU Electronics DPP'. Since the repairability heuristic is now documented as non-regulatory and its 0–10 scale is not comparable to official indices, these references should be updated to avoid implying regulatory enforcement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
Removes a fabricated regulatory timeline from two published schemas and corrects the CFB delegated-act status. No behaviour change; full gate green.
Detail:
dpp-docs/work/sector-expansion/DOC-TRUTH-CORRECTIONS.md