You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adding a sector currently ships a silently degraded AAS mapping. The
dispatch in aas::sectors ends in a deliberate catch-all that renders an
unmodelled SectorData variant as a generic key-value submodel with no
semantic IDs. The fallback is right for forward compatibility, but it
means a missing builder produces no build error and no test failure —
just lower-fidelity interop output on a surface the EN 1822x work
depends on.
Two tests close the gap without removing the fallback: every catalog
sector must appear in the AAS case table, and no sector may resolve to
the generic builder.
The coverage test found battery absent from a table whose own docs claim
it feeds every sector. Battery is exercised by battery_end_to_end.rs, so
it is listed as covered elsewhere rather than duplicated here.
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
The PR introduces effective guard tests to ensure all defined sectors (excluding 'battery') are correctly mapped in the AAS implementation and do not fallback to generic 'SectorData' representations. The implementation aligns with the stated acceptance criteria.
Codacy analysis confirms the code is up to standards, with no new issues or complexity regressions. Two minor cosmetic nits regarding whitespace in assertion messages were identified; addressing these will improve the readability of failure logs should the tests trigger in the future.
Test suggestions
Verify all catalog sectors are linked to AAS test cases
Verify no AAS output for catalog sectors utilizes the generic 'SectorData' fallback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
A new sector currently ships a degraded AAS submodel with no build or test failure. Two tests close that without removing the forward-compat fallback.
Found in passing: battery is absent from a table documented as covering every sector (it has its own E2E test, so it's listed as covered elsewhere).
Gate green.