Show the retry time when the sign-in code is rate limited#815
Merged
Conversation
Return retryAfterSeconds (and a Retry-After header) on the 429 from generateSignInCode, and show "try again in about X minutes" on the email and OTP screens for the hourly-cap case; short cooldowns keep the "wait a moment" message. Raise the hourly cap from 5 to 10 to give legitimate retries more headroom.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on the sign-in code rate limiting. The 429 response now includes retryAfterSeconds (and a Retry-After header), threaded through to the UI so the email-login form and the OTP screen show a clear 'please try again in about X minutes' message for the hourly-cap case (short cooldowns keep the existing 'wait a moment' message). Also raises the hourly cap from 5 to 10 so legitimate retries (lost emails, spam folder) have more headroom before hitting it. Adds a rateLimitMessage helper + tests, backend retry-time tests, and reducer/OTP coverage.